From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Steve French <smfrench@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-cifs-client@lists.samba.org,
linux-kernel@vger.kernel.org
Subject: Re: [linux-cifs-client] [PATCH] cifs: wrap cifs_dnotify_thread in CONFIG_BROKEN
Date: Thu, 22 Jan 2009 19:13:07 -0500 [thread overview]
Message-ID: <20090123001306.GA2176@infradead.org> (raw)
In-Reply-To: <20090122183115.1cef1b53@tleilax.poochiereds.net>
On Thu, Jan 22, 2009 at 06:31:15PM -0500, Jeff Layton wrote:
> Removing this kthread won't measurably move us farther away from that
> goal either.
>
> It's currently under CONFIG_CIFS_EXPERIMENTAL, which would be fine if
> it actually did something. It doesn't though -- it just wakes up tasks
> that don't need to be woken up.
>
> I have no issue with a kthread that does useful work, but why not remove
> this kthread out of the mainline code for now and just plan to put it
> back when it actually has something useful to do?
>
> The patch that removes it will live in perpetuity in git. It'll be a
> trivial matter to revert it when you're ready to have the kthread do
> real work.
Yeah. Currently it's useless code. If a proper *notify implementation
for cifs still needs a thread it can be added with that implementation,
and I'm sure it'll look very different from the current one (at least
after review..)
prev parent reply other threads:[~2009-01-23 0:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 16:34 [PATCH] cifs: wrap cifs_dnotify_thread in CONFIG_BROKEN Jeff Layton
2009-01-22 21:06 ` [linux-cifs-client] " Christoph Hellwig
2009-01-22 23:13 ` Steve French
2009-01-22 23:31 ` Jeff Layton
2009-01-22 23:41 ` Steve French
2009-01-22 23:56 ` Steve French
2009-01-23 1:17 ` Jeff Layton
2009-01-23 0:13 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090123001306.GA2176@infradead.org \
--to=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox