public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Matt Mackall <mpm@selenic.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org, andi@firstfloor.org,
	viro@ZenIV.linux.org.uk, oleg@redhat.com,
	linux-api@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH, RFC] Remove fasync() BKL usage, take 3325
Date: Fri, 23 Jan 2009 07:15:57 +0100	[thread overview]
Message-ID: <20090123061557.GM15750@one.firstfloor.org> (raw)
In-Reply-To: <1232689549.5202.385.camel@calx>

> I have to agree with Christoph. The priority here is breaking down the
> BKL and document all the things being protected by it and we've got a
> reasonably obvious patch in that direction. Meanwhile, there's not
> currently a pressing demand to make fasync in particular scale that I'm
> aware of.

The classic case is a high throughput network server that uses async
sockets. It has to call F_SETFL on each new socket it opens.

> Having a single big lock here is quite possibly something we'll want to
> fix down the road, agreed, but until we can actually measure it hurting
> us, debating about whether to use a bit lock or reuse an existing lock
> or add a new lock to all struct files is a bit premature.

I think i would agree with you if we didn't have a better patch
already, but if there's one it doesn't make sense not to use it.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.

  reply	other threads:[~2009-01-23  6:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-15 22:32 [PATCH, RFC] Remove fasync() BKL usage, take 3325 Jonathan Corbet
2009-01-22 14:51 ` Andrew Morton
2009-01-22 16:09   ` Andi Kleen
2009-01-23  5:21     ` Jonathan Corbet
2009-01-22 20:32   ` Christoph Hellwig
2009-01-23  4:56     ` Andi Kleen
2009-01-28  0:53       ` Andrew Morton
2009-01-28  0:55       ` Andrew Morton
2009-01-28  3:14         ` Oleg Nesterov
2009-01-28  3:57           ` Jonathan Corbet
2009-01-28  4:23             ` Oleg Nesterov
2009-01-28 14:13               ` Jonathan Corbet
2009-01-28 17:36           ` Christoph Hellwig
2009-01-28 17:44             ` Jonathan Corbet
2009-01-28 17:55               ` Christoph Hellwig
2009-01-28 18:13                 ` Matt Mackall
2009-01-28 21:05                   ` Jonathan Corbet
2009-01-28 18:14             ` David Daney
2009-01-29 14:37             ` Andi Kleen
2009-01-23  5:15   ` Jonathan Corbet
2009-01-23  5:31     ` Andrew Morton
2009-01-23  5:45       ` Matt Mackall
2009-01-23  6:15         ` Andi Kleen [this message]
2009-01-23 10:45           ` Bernd Petrovitsch
2009-01-23  5:54       ` Andi Kleen
2009-01-23  6:01         ` Jonathan Corbet
2009-01-23  6:57         ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090123061557.GM15750@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=corbet@lwn.net \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    --cc=oleg@redhat.com \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox