From: David Brownell <david-b@pacbell.net>
To: Bryan Wu <cooloney@kernel.org>
Cc: gregkh@suse.de, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: composite: Fix bug: should test set_alt function pointer before use it
Date: Fri, 23 Jan 2009 21:59:18 -0800 [thread overview]
Message-ID: <200901232159.18863.david-b@pacbell.net> (raw)
In-Reply-To: <1231345279-26618-2-git-send-email-cooloney@kernel.org>
On Wednesday 07 January 2009, Bryan Wu wrote:
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
Include a real patch comment -- "test the *correct* function
pointer" would suffice, and:
Acked-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/usb/gadget/composite.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index f2da026..363951e 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -772,7 +772,7 @@ composite_setup(struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl)
> f = cdev->config->interface[w_index];
> if (!f)
> break;
> - if (w_value && !f->get_alt)
> + if (w_value && !f->set_alt)
> break;
> value = f->set_alt(f, w_index, w_value);
> break;
> --
> 1.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2009-01-24 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 16:21 [PATCH 0/2] Bugs fixing for USB composite gadget driver Bryan Wu
2009-01-07 16:21 ` [PATCH 1/2] usb: composite: Fix bug: should test set_alt function pointer before use it Bryan Wu
2009-01-24 5:59 ` David Brownell [this message]
2009-01-07 16:21 ` [PATCH 2/2] usb: composite: Fix bug: low byte of w_index is the usb interface number not the whole 2 bytes of w_index Bryan Wu
2009-01-24 6:00 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901232159.18863.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=cooloney@kernel.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox