From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: reiserfs-devel@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: usr/include/linux/reiserfs_fs.h is having lot of KERNEL data
Date: Sat, 24 Jan 2009 10:32:36 +0300 [thread overview]
Message-ID: <20090124073236.GA6166@x200.localdomain> (raw)
In-Reply-To: <1232778934.10414.4.camel@localhost.localdomain>
On Sat, Jan 24, 2009 at 12:05:34PM +0530, Jaswinder Singh Rajput wrote:
> On Tue, 2009-01-20 at 20:57 +0530, Jaswinder Singh Rajput wrote:
> > usr/include/linux/reiserfs_fs.h is giving 21 'make headers_clean' warnings:
> > usr/include/linux/reiserfs_fs.h:64: leaks CONFIG_REISERFS to userspace where it is not valid
> > usr/include/linux/reiserfs_fs.h:81: leaks CONFIG_REISERFS to userspace where it is not valid
> > usr/include/linux/reiserfs_fs.h:687: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:995: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:997: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1467: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1587: leaks CONFIG_QUOTA to userspace where it is not valid
> > usr/include/linux/reiserfs_fs.h:1760: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1764: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1766: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1769: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1771: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1805: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1908: leaks CONFIG_PROC to userspace where it is not valid
> > usr/include/linux/reiserfs_fs.h:1948: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1949: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1950: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1951: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1962: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1963: extern's make no sense in userspace
> > usr/include/linux/reiserfs_fs.h:1964: extern's make no sense in userspace
> >
> > This file is huge and need lot of cleanup.
> >
>
>
> If no one have any objections can I forward this patch to fix above
> warnings:
This file need more throrough cleanup than some tool thinks it needs to be:
> --- a/include/linux/reiserfs_fs.h
> +++ b/include/linux/reiserfs_fs.h
> @@ -74,9 +74,7 @@ struct fid;
> // FIXME: do not change 4 by anything else: there is code which relies on that
> #define ROUND_UP(x) _ROUND_UP(x,8LL)
>
> -/* debug levels. Right now, CONFIG_REISERFS_CHECK means print all debug
> -** messages.
> -*/
> +/* debug levels. Right now, REISERFS_CHECK means print all debug messages */
Whoa, fix the tool!
> @@ -91,11 +89,13 @@ if( !( cond ) ) \
>
> #define RASSERT(cond, format, args...) __RASSERT(cond, #cond, format, ##args)
>
> +#ifdef __KERNEL__
What about RASSERT?
> #if defined( CONFIG_REISERFS_CHECK )
> #define RFALSE(cond, format, args...) __RASSERT(!(cond), "!(" #cond ")", format, ##args)
> #else
> #define RFALSE( cond, format, args... ) do {;} while( 0 )
> #endif
> +#endif
>
> #define CONSTF __attribute_const__
> /*
> @@ -698,7 +698,9 @@ static inline void cpu_key_k_offset_dec(struct cpu_key *key)
> /* object identifier for root dir */
> #define REISERFS_ROOT_OBJECTID 2
> #define REISERFS_ROOT_PARENT_OBJECTID 1
> +#ifdef __KERNEL__
> extern struct reiserfs_key root_key;
> +#endif /* __KERNEL__ */
>
> /*
> * Picture represents a leaf of the S+tree
> @@ -1006,10 +1008,12 @@ struct reiserfs_de_head {
> #define de_visible(deh) test_bit_unaligned (DEH_Visible, &((deh)->deh_state))
> #define de_hidden(deh) !test_bit_unaligned (DEH_Visible, &((deh)->deh_state))
>
> +#ifdef __KERNEL__
> extern void make_empty_dir_item_v1(char *body, __le32 dirid, __le32 objid,
> __le32 par_dirid, __le32 par_objid);
> extern void make_empty_dir_item(char *body, __le32 dirid, __le32 objid,
> __le32 par_dirid, __le32 par_objid);
> +#endif /* __KERNEL__ */
>
> /* array of the entry headers */
> /* get item body */
> @@ -1478,7 +1482,9 @@ struct item_operations {
> void (*print_vi) (struct virtual_item * vi);
> };
>
> +#ifdef __KERNEL__
> extern struct item_operations *item_ops[TYPE_ANY + 1];
> +#endif /* __KERNEL__ */
item_ops are unused, AFAICS.
> @@ -1688,6 +1696,7 @@ struct reiserfs_jh {
struct reiserfs_jh is kernel-internal as well.
next prev parent reply other threads:[~2009-01-24 7:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 15:27 usr/include/linux/reiserfs_fs.h is having lot of KERNEL data Jaswinder Singh Rajput
2009-01-24 6:35 ` Jaswinder Singh Rajput
2009-01-24 7:32 ` Alexey Dobriyan [this message]
2009-01-24 7:43 ` Sam Ravnborg
2009-01-24 18:42 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090124073236.GA6166@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox