From: Ingo Molnar <mingo@elte.hu>
To: john stultz <johnstul@us.ibm.com>
Cc: "Miklos Vajna" <vmiklos@frugalware.org>,
"Florian Fainelli" <florian.fainelli@telecomint.eu>,
linux-kernel@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Gabriel C" <nix.or.die@googlemail.com>,
"CSÉCSY László" <boobaa@frugalware.org>,
r.schwebel@pengutronix.de, sven@geggus.net
Subject: Re: System clock runs too fast after 2.6.27 -> 2.6.28.1 upgrade
Date: Sat, 24 Jan 2009 10:14:04 +0100 [thread overview]
Message-ID: <20090124091404.GA32032@elte.hu> (raw)
In-Reply-To: <1f1b08da0901231736u46d8981ckc4b89ac66d7d8a5e@mail.gmail.com>
* john stultz <johnstul@us.ibm.com> wrote:
> On Fri, Jan 23, 2009 at 3:04 AM, Ingo Molnar <mingo@elte.hu> wrote:
> > * john stultz <johnstul@us.ibm.com> wrote:
> >> I'd think this would ideally be more of a subarch in the config
> >> selection like the AMD Elan is, so folks know it really is not just a
> >> extra-support feature and in fact limits what hardware you can use the
> >> resulting kernel on.
> >
> > a better solution is that if RDC is set [it is unset by default] we should
> > turn PIT_TICK_RATE into a variable, defaulting it to 1193182. If a real
> > RDC or ELAN system is running, that variable is changed during early
> > bootup, in the init functions for those platforms.
>
> Took a quick look at this, and I don't see any detection code for either
> RDC. The X86_ELAN config also has no conditionals, but maybe the elan
> cpufreq code can help here.
i'd suggest to just remove the #ifdef for now (it's causing problems) and
add the variable - we can add the quirks for those two platforms later on,
separately from your patch(es).
Ingo
next prev parent reply other threads:[~2009-01-24 9:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 17:14 System clock runs too fast after 2.6.27 -> 2.6.28.1 upgrade Miklos Vajna
2009-01-21 20:00 ` john stultz
2009-01-21 21:07 ` Miklos Vajna
2009-01-21 21:34 ` john stultz
2009-01-22 19:51 ` Miklos Vajna
2009-01-22 19:55 ` Ingo Molnar
2009-01-23 0:12 ` Miklos Vajna
2009-01-22 20:03 ` john stultz
2009-01-22 23:57 ` Miklos Vajna
2009-01-23 1:43 ` john stultz
2009-01-23 11:04 ` Ingo Molnar
2009-01-24 1:36 ` john stultz
2009-01-24 9:14 ` Ingo Molnar [this message]
2009-01-25 11:18 ` Florian Fainelli
2009-01-25 15:03 ` Ingo Molnar
2009-01-25 15:38 ` Florian Fainelli
2009-01-25 16:00 ` Ingo Molnar
2009-01-25 11:17 ` Florian Fainelli
2009-01-25 15:02 ` Ingo Molnar
2009-01-25 14:59 ` Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090124091404.GA32032@elte.hu \
--to=mingo@elte.hu \
--cc=boobaa@frugalware.org \
--cc=florian.fainelli@telecomint.eu \
--cc=hpa@zytor.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nix.or.die@googlemail.com \
--cc=r.schwebel@pengutronix.de \
--cc=rjw@sisk.pl \
--cc=sven@geggus.net \
--cc=tglx@linutronix.de \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox