From: Greg KH <greg@kroah.com>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Cc: Greg KH <gregkh@suse.de>, Mike Frysinger <vapier.adi@gmail.com>,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: debugfs & vfs file permission issue?
Date: Sun, 25 Jan 2009 13:34:03 -0800 [thread overview]
Message-ID: <20090125213403.GB3600@kroah.com> (raw)
In-Reply-To: <200901061012.38888.rgetz@blackfin.uclinux.org>
On Tue, Jan 06, 2009 at 10:12:38AM -0500, Robin Getz wrote:
> On Tue 6 Jan 2009 07:05, Robin Getz suggested:
> >
> > adding a readonly, and writeonly, and ensuring that when you call
> > debugfs_create_*, the mode is checked, and the "correct" fops are set
> > doesn't seem like it would be a bad idea? This would enforce the
> > kernel programmer's view on the world, and not allow pesky root users
> > to override things....
> >
> > Greg - would you take something like that?
>
> How about this?
>
> Feel free to nak it - we can do the same thing where we are calling the
> debugfs_create_* functions - this just makes it cleaner in my opinion.
I like the patch, but there are no changes to the debugfs.h file, which
I think you need.
Care to resend it with the needed header file changes so that I can
apply it?
thanks,
greg k-h
next prev parent reply other threads:[~2009-01-25 21:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 2:57 debugfs & vfs file permission issue? Robin Getz
2009-01-06 5:48 ` Greg KH
2009-01-06 5:54 ` Mike Frysinger
2009-01-06 6:19 ` Greg KH
2009-01-06 6:32 ` Mike Frysinger
2009-01-06 12:05 ` Robin Getz
2009-01-06 15:12 ` Robin Getz
2009-01-06 15:20 ` Mike Frysinger
2009-01-06 21:20 ` Robin Getz
2009-01-06 23:11 ` Greg KH
2009-01-07 3:30 ` Robin Getz
2009-01-25 21:34 ` Greg KH [this message]
2009-06-02 7:00 ` [PATCH] debugfs: use specified mode to possibly mark files read/write only Mike Frysinger
2009-06-02 23:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090125213403.GB3600@kroah.com \
--to=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rgetz@blackfin.uclinux.org \
--cc=vapier.adi@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox