From: Andy Whitcroft <apw@canonical.com>
To: Andrey Borzenkov <arvidjaar@mail.ru>
Cc: Pavel Roskin <proski@gnu.org>, linux-kernel@vger.kernel.org
Subject: Re: checkpatch vs. checkpatch --file (was: Re: [Orinoco-devel] [PATCH] orinoco: checkpatch cleanup)
Date: Mon, 26 Jan 2009 08:38:30 +0000 [thread overview]
Message-ID: <20090126083830.GA17399@shadowen.org> (raw)
In-Reply-To: <200901260713.39734.arvidjaar@mail.ru>
On Mon, Jan 26, 2009 at 07:13:36AM +0300, Andrey Borzenkov wrote:
> On 26 января 2009 06:46:02 Pavel Roskin wrote:
> >
> > Please run the patch itself through checkpatch. It finds two errors:
> >
> > ERROR: trailing statements should be on next line
> > #163: FILE: drivers/net/wireless/orinoco/hermes.c:65:
> > + printk(stuff); } while (0)
> > + printk(stuff); } while (0)
>
> I ran "checkpatch --file hermes.c" after editing it and it found zero
> errors.
>
> Cc checkpatch maintainer.
Hmmm. Could I have the patch and the file either before or after
application please.
Very strange.
-apw
next parent reply other threads:[~2009-01-26 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200901252254.32137.arvidjaar@mail.ru>
[not found] ` <200901252308.45889.arvidjaar@mail.ru>
[not found] ` <1232941562.1604.4.camel@dv>
[not found] ` <200901260713.39734.arvidjaar@mail.ru>
2009-01-26 8:38 ` Andy Whitcroft [this message]
2009-01-26 16:06 ` checkpatch vs. checkpatch --file (was: Re: [Orinoco-devel] [PATCH] orinoco: checkpatch cleanup) Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090126083830.GA17399@shadowen.org \
--to=apw@canonical.com \
--cc=arvidjaar@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox