[PATCH] hp-wmi: set initial docking state

[PATCH] hp-wmi: set initial docking state

[Frans Pop]

If the initial state is not set when the input device is set up, the
first docking event after the module is loaded will be lost.
    
Signed-off-by: Frans Pop <elendil@planet.nl>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
---
Patch is based on what is done for the LID switch in drivers/acpi/button.c 
and has been tested on my HP 2510p.

As this is a (minor) bug fix, it would be nice to have it in 2.6.29.

Cheers,
FJP

diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index 7c789f0..8aaff0c 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -382,6 +382,11 @@ static int __init hp_wmi_input_setup(void)
 		case KE_SW:
 			set_bit(EV_SW, hp_wmi_input_dev->evbit);
 			set_bit(key->keycode, hp_wmi_input_dev->swbit);
+
+			/* Set initial dock state */
+			input_report_switch(hp_wmi_input_dev, key->keycode,
+					    hp_wmi_dock_state());
+			input_sync(hp_wmi_input_dev);
 			break;
 		}
 	}

Re: [PATCH] hp-wmi: set initial docking state

[Matthew Garrett]

On Mon, Jan 26, 2009 at 03:36:01PM +0100, Frans Pop wrote:
> If the initial state is not set when the input device is set up, the
> first docking event after the module is loaded will be lost.
>     
> Signed-off-by: Frans Pop <elendil@planet.nl>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Acked-by: Matthew Garrett <mjg@redhat.com>

-- 
Matthew Garrett | mjg59@srcf.ucam.org