Re: [PATCH] pids: kill now unused signal_struct-> __pgrp/__session and friends

[Andrew Morton <akpm@linux-foundation.org>]

On Mon, 19 Jan 2009 23:05:54 +0100 Oleg Nesterov <oleg@redhat.com> wrote:

> [PATCH -mm] pids: kill signal_struct-> __pgrp/__session and friends
> 
> (depends on pids-refactor-vnr-nr_ns-helpers-to-make-them-safe.patch)
> 
> We are wasting 2 words in signal_struct without any reason to implement
> task_pgrp_nr() and task_session_nr().
> 
> task_session_nr() has no callers since 2e2ba22ea4fd4bb85f0fa37c521066db6775cbef,
> we can remove it.
> 
> task_pgrp_nr() is still (I believe wrongly) used in fs/autofsX and fs/coda.
> 
> This patch reimplements task_pgrp_nr() via task_pgrp_nr_ns(), and kills
> __pgrp/__session and the related helpers.
> 
> The change in drivers/char/tty_io.c is cosmetic, but hopefully makes sense
> anyway.

hm, that's a fairly deep-looking patch.

You missed the fun bit:

 drivers/char/tty_io.c |    4 +--
 include/linux/sched.h |   43 +++++-----------------------------------
 kernel/exit.c         |   10 ++-------
 kernel/fork.c         |    2 -
 kernel/sys.c          |    4 ---
 5 files changed, 12 insertions(+), 51 deletions(-)

> TTY-parts-Acked-by: Alan Cox <number6@the-village.bc.nu>

who is that masked man?