Re: [Bug 12492] Re: [patch 1/2] stop_machine: introduce stop_machine_create/destroy.

Heiko Carstens
2009-01-27T10:09:31Z

On Tue, 27 Jan 2009 01:52:02 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Tue, 27 Jan 2009 00:04:32 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> > Commit 9ea09af3bd3090e8349ca2899ca2011bd94cda85 introduced a
> > regression that caused the kernel to fail to suspend. The 'sleeping'
> > LED on the laptop just keeps blinking and the laptop never shuts
> > down. I think this was eventually fixed because with 2.6.29-rc1 and
> > -rc2 the laptop suspends fine, but fails to resume. When I try to
> > resume, all I see is a blinking cursor in the top left corner of the
> > screen.
> >
> > I'm using acpi_sleep=s3_bios,s3_mode, suspending using a script
> > that does: echo mem > /sys/power/state.
>
> hm. Re-reading this, it seems to be saying that
> 9ea09af3bd3090e8349ca2899ca2011bd94cda85 might be innocent, and that
> some other patch might have caused the resume regression?

Yes, I already updated the bugzilla entry at kernel.org:

The bug introduced with the introduction of stop_machine_create/destroy
was fixed with a0e280e0f33f6c859a235fb69a875ed8f3420388
"stop_machine/cpu hotplug: fix disable_nonboot_cpus".
Must be something else.