From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbZA0JyB (ORCPT ); Tue, 27 Jan 2009 04:54:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752144AbZA0Jxw (ORCPT ); Tue, 27 Jan 2009 04:53:52 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:36973 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbZA0Jxw (ORCPT ); Tue, 27 Jan 2009 04:53:52 -0500 Date: Tue, 27 Jan 2009 01:52:02 -0800 From: Andrew Morton To: Heiko Carstens , Rusty Russell , linux-kernel@vger.kernel.org, Tomas Carnecky , bugme-daemon@bugzilla.kernel.org Subject: Re: [Bug 12492] Re: [patch 1/2] stop_machine: introduce stop_machine_create/destroy. Message-Id: <20090127015202.486dd1af.akpm@linux-foundation.org> In-Reply-To: <20090127000432.65042e85.akpm@linux-foundation.org> References: <20081222113629.080104676@de.ibm.com> <20081222114529.601526881@de.ibm.com> <20090127000432.65042e85.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Jan 2009 00:04:32 -0800 Andrew Morton wrote: > On Mon, 22 Dec 2008 12:36:30 +0100 Heiko Carstens wrote: > > > Introduce stop_machine_create/destroy. With this interface subsystems > > that need a non-failing stop_machine environment can create the > > stop_machine machine threads before actually calling stop_machine. > > When the threads aren't needed anymore they can be killed with > > stop_machine_destroy again. > > > > When stop_machine gets called and the threads aren't present they > > will be created and destroyed automatically. This restores the old > > behaviour of stop_machine. > > > > This patch also converts cpu hotplug to the new interface since it > > is special: cpu_down calls __stop_machine instead of stop_machine. > > However the kstop threads will only be created when stop_machine > > gets called. > > > > Changing the code so that the threads would be created automatically > > on __stop_machine is currently not possible: when __stop_machine gets > > called we hold cpu_add_remove_lock, which is the same lock that > > create_rt_workqueue would take. So the workqueue needs to be created > > before the cpu hotplug code locks cpu_add_remove_lock. > > In http://bugzilla.kernel.org/show_bug.cgi?id=12492, Thomas (cc'ed > here) reports > > Commit 9ea09af3bd3090e8349ca2899ca2011bd94cda85 introduced a > regression that caused the kernel to fail to suspend. The 'sleeping' > LED on the laptop just keeps blinking and the laptop never shuts > down. I think this was eventually fixed because with 2.6.29-rc1 and > -rc2 the laptop suspends fine, but fails to resume. When I try to > resume, all I see is a blinking cursor in the top left corner of the > screen. > > I'm using acpi_sleep=s3_bios,s3_mode, suspending using a script > that does: echo mem > /sys/power/state. > hm. Re-reading this, it seems to be saying that 9ea09af3bd3090e8349ca2899ca2011bd94cda85 might be innocent, and that some other patch might have caused the resume regression?