Re: [PATCH v3] tcp: splice as many packets as possible at once

Herbert Xu
2009-01-27T07:14:11Z

David Miller <davem@davemloft.net> wrote:
> From: Jarek Poplawski <jarkao2@gmail.com>
> Date: Thu, 22 Jan 2009 09:04:42 +0000
>
>> It seems this sk_sndmsg_page usage (refcounting) isn't consistent.
>> I used here tcp_sndmsg() way, but I think I'll go back to this question
>> soon.
>
> Indeed, it is something to look into, as well as locking.
>
> I'll try to find some time for this, thanks Jarek.

After a quick look it seems to be OK to me. The code in the patch
is called from tcp_splice_read, which holds the socket lock. So as
long as the patch uses the usual TCP convention it should work.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt