[patch 002/104] USB: gadget rndis: stop windows self-immolation

Greg KH
2008-12-03T19:50:51Z

[-- Attachment #1: usb-gadget-rndis-stop-windows-self-immolation.patch --]
[-- Type: text/plain, Size: 1199 bytes --]

2.6.27-stable review patch. If anyone has any objections, please let us know.

------------------
From: David Brownell <dbrownell@users.sourceforge.net>

commit 9c264521a9f836541c122b00f505cfd60cc5bbb5 upstream.

Somewhere in the conversion of the RNDIS gadget code to the new
framework, the descriptor of its data interface seems to have
been copied from the CDC Ethernet driver. Unfortunately that
means it got a nonzero altsetting ... which is incorrect. Issue
uncovered by Richard Röjfors <richard.rojfors@endian.se>.

This patch fixes that problem, and resolves at least some cases
of Windows XP bluescreening itself.

Tested-by: Richard Röjfors <richard.rojfors@endian.se>.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
drivers/usb/gadget/f_rndis.c | 1 -
1 file changed, 1 deletion(-)

--- a/drivers/usb/gadget/f_rndis.c
+++ b/drivers/usb/gadget/f_rndis.c
@@ -172,7 +172,6 @@ static struct usb_interface_descriptor r
.bDescriptorType = USB_DT_INTERFACE,

/* .bInterfaceNumber = DYNAMIC */
- .bAlternateSetting = 1,
.bNumEndpoints = 2,
.bInterfaceClass = USB_CLASS_CDC_DATA,
.bInterfaceSubClass = 0,