Re: [patch 011/104] fbdev: clean the penguins dirty feet

Henrique de Moraes Holschuh
2008-12-05T19:29:44Z

(Cc: trimmed)

On Fri, 05 Dec 2008, Pavel Machek wrote:
> > commit cf7ee554f3a324e98181b0ea249d9d5be3a0acb8 upstream.
> >
> > When booting in a direct color mode, the penguin has dirty feet, i.e.,
> > some pixels have the wrong color. This is caused by
> > fb_set_logo_directpalette() which does not initialize the last 32 palette
> > entries.
>
> Heh, funny, but... is this really bad enough bug to go to stable?

Well, it is a public health problem, since dirty feet in Penguins can spread
numerous diseases.

Imagine the *horror* if your box got the dreaded dancing-penguin disease
from those nasty dirty feet, and started trying to sing and dance... while
still booting! It would be quite out of wack, and be horribly off-tune!
And if it happens on a PeeCee, it would be trying to sing its lungs off
through the DREADED PeeCee Squeaker...

That just Cannot Be Allowed To Happen(TM).

> > - for (i = 32; i < logo->clutsize; i++)
> > + for (i = 32; i < 32 + logo->clutsize; i++)

It is an one line change that can save us from untold horrors! I call that
a patch well deserving of being in a stable release ;-)

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh