Re: [patch 011/104] fbdev: clean the penguins dirty feet

Andrew Morton
2008-12-06T02:49:18Z

On Fri, 5 Dec 2008 13:58:55 +0100 Pavel Machek <pavel@suse.cz> wrote:

> On Wed 2008-12-03 11:48:38, Greg KH wrote:
> > 2.6.27-stable review patch. If anyone has any objections, please let us know.
> >
> > ------------------
> > From: Clemens Ladisch <clemens@ladisch.de>
> >
> > commit cf7ee554f3a324e98181b0ea249d9d5be3a0acb8 upstream.
> >
> > When booting in a direct color mode, the penguin has dirty feet, i.e.,
> > some pixels have the wrong color. This is caused by
> > fb_set_logo_directpalette() which does not initialize the last 32 palette
> > entries.
>
> Heh, funny, but... is this really bad enough bug to go to stable?

Borderline. But the patch was pretty simple.

Also, there's the question "is this the sort of bug which distro
customers are likely to report to the distros". I figure "yes", and I
figure that the distros would like us to fix it for them. Of course,
I might be wrong about one or both of those things ;)