From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: mingo@elte.hu, efault@gmx.de
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: [PATCH 1/3] sched: symmetric sync vs avg_overlap
Date: Wed, 28 Jan 2009 14:51:38 +0100 [thread overview]
Message-ID: <20090128135253.599881679@chello.nl> (raw)
In-Reply-To: 20090128135137.632938951@chello.nl
[-- Attachment #1: sched-sync_vs_overlap.patch --]
[-- Type: text/plain, Size: 1028 bytes --]
Reinstate the weakening of the sync hint if set. This yields a more
symmetric usage of avg_overlap.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
kernel/sched.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
Index: linux-2.6/kernel/sched.c
===================================================================
--- linux-2.6.orig/kernel/sched.c
+++ linux-2.6/kernel/sched.c
@@ -2360,9 +2360,15 @@ static int try_to_wake_up(struct task_st
if (!sched_feat(SYNC_WAKEUPS))
sync = 0;
- if (!sync && (current->se.avg_overlap < sysctl_sched_migration_cost &&
- p->se.avg_overlap < sysctl_sched_migration_cost))
- sync = 1;
+ if (!sync) {
+ if (current->se.avg_overlap < sysctl_sched_migration_cost &&
+ p->se.avg_overlap < sysctl_sched_migration_cost)
+ sync = 1;
+ } else {
+ if (current->se.avg_overlap >= sysctl_sched_migration_cost ||
+ p->se.avg_overlap >= sysctl_sched_migration_cost)
+ sync = 0;
+ }
#ifdef CONFIG_SMP
if (sched_feat(LB_WAKEUP_UPDATE)) {
--
next prev parent reply other threads:[~2009-01-28 13:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 13:51 [PATCH 0/3] sched: pending patches Peter Zijlstra
2009-01-28 13:51 ` Peter Zijlstra [this message]
2009-01-28 13:51 ` [PATCH 2/3] sched: clear buddies more aggressively Peter Zijlstra
2009-01-28 13:51 ` [PATCH 3/3] sched: fix buddie group latency Peter Zijlstra
2009-01-29 12:27 ` [PATCH 0/3] sched: pending patches Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128135253.599881679@chello.nl \
--to=a.p.zijlstra@chello.nl \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox