* [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus
@ 2009-01-28 14:33 Arnaldo Carvalho de Melo
2009-01-28 14:53 ` Frédéric Weisbecker
2009-01-29 13:28 ` Ingo Molnar
0 siblings, 2 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2009-01-28 14:33 UTC (permalink / raw)
To: Ingo Molnar
Cc: Jens Axboe, Frédéric Weisbecker,
Linux Kernel Mailing List
Impact: cleanup
Use tracing_reset_online_cpus instead of open coding it.
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
diff --git a/block/blktrace.c b/block/blktrace.c
index 1b2267c..04d81d3 100644
--- a/block/blktrace.c
+++ b/block/blktrace.c
@@ -1109,12 +1109,7 @@ static void blk_tracer_print_header(struct seq_file *m)
static void blk_tracer_start(struct trace_array *tr)
{
- int cpu;
-
- tr->time_start = ftrace_now(tr->cpu);
-
- for_each_online_cpu(cpu)
- tracing_reset(tr, cpu);
+ tracing_reset_online_cpus(tr);
mutex_lock(&blk_probe_mutex);
if (atomic_add_return(1, &blk_probes_ref) == 1)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus
2009-01-28 14:33 [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus Arnaldo Carvalho de Melo
@ 2009-01-28 14:53 ` Frédéric Weisbecker
2009-01-28 14:58 ` Arnaldo Carvalho de Melo
2009-01-29 13:28 ` Ingo Molnar
1 sibling, 1 reply; 4+ messages in thread
From: Frédéric Weisbecker @ 2009-01-28 14:53 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Ingo Molnar, Jens Axboe,
Frédéric Weisbecker, Linux Kernel Mailing List,
Steven Rostedt
2009/1/28 Arnaldo Carvalho de Melo <acme@ghostprotocols.net>:
> Impact: cleanup
>
> Use tracing_reset_online_cpus instead of open coding it.
>
> Cc: Jens Axboe <jens.axboe@oracle.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> diff --git a/block/blktrace.c b/block/blktrace.c
> index 1b2267c..04d81d3 100644
> --- a/block/blktrace.c
> +++ b/block/blktrace.c
> @@ -1109,12 +1109,7 @@ static void blk_tracer_print_header(struct seq_file *m)
>
> static void blk_tracer_start(struct trace_array *tr)
> {
> - int cpu;
> -
> - tr->time_start = ftrace_now(tr->cpu);
> -
> - for_each_online_cpu(cpu)
> - tracing_reset(tr, cpu);
> + tracing_reset_online_cpus(tr);
>
> mutex_lock(&blk_probe_mutex);
> if (atomic_add_return(1, &blk_probes_ref) == 1)
>
Adding Steven in Cc, he uses to relay tracing patches as patchsets
pull request to Ingo.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus
2009-01-28 14:53 ` Frédéric Weisbecker
@ 2009-01-28 14:58 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2009-01-28 14:58 UTC (permalink / raw)
To: Frédéric Weisbecker
Cc: Ingo Molnar, Jens Axboe, Linux Kernel Mailing List,
Steven Rostedt
Em Wed, Jan 28, 2009 at 03:53:48PM +0100, Frédéric Weisbecker escreveu:
> 2009/1/28 Arnaldo Carvalho de Melo <acme@ghostprotocols.net>:
> > Impact: cleanup
> >
> > Use tracing_reset_online_cpus instead of open coding it.
> >
> > Cc: Jens Axboe <jens.axboe@oracle.com>
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> >
> > diff --git a/block/blktrace.c b/block/blktrace.c
> > index 1b2267c..04d81d3 100644
> > --- a/block/blktrace.c
> > +++ b/block/blktrace.c
> > @@ -1109,12 +1109,7 @@ static void blk_tracer_print_header(struct seq_file *m)
> >
> > static void blk_tracer_start(struct trace_array *tr)
> > {
> > - int cpu;
> > -
> > - tr->time_start = ftrace_now(tr->cpu);
> > -
> > - for_each_online_cpu(cpu)
> > - tracing_reset(tr, cpu);
> > + tracing_reset_online_cpus(tr);
> >
> > mutex_lock(&blk_probe_mutex);
> > if (atomic_add_return(1, &blk_probes_ref) == 1)
> >
>
> Adding Steven in Cc, he uses to relay tracing patches as patchsets
> pull request to Ingo.
Ok, will add him for the next one.
- Arnaldo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus
2009-01-28 14:33 [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus Arnaldo Carvalho de Melo
2009-01-28 14:53 ` Frédéric Weisbecker
@ 2009-01-29 13:28 ` Ingo Molnar
1 sibling, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2009-01-29 13:28 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Jens Axboe,
Frédéric Weisbecker, Linux Kernel Mailing List
* Arnaldo Carvalho de Melo <acme@redhat.com> wrote:
> Impact: cleanup
>
> Use tracing_reset_online_cpus instead of open coding it.
>
> Cc: Jens Axboe <jens.axboe@oracle.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>
> diff --git a/block/blktrace.c b/block/blktrace.c
> index 1b2267c..04d81d3 100644
Applied to tip/tracing/blktrace, thanks Arnaldo!
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-29 13:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-28 14:33 [PATCH tip 1/1] blktrace: Use tracing_reset_online_cpus Arnaldo Carvalho de Melo
2009-01-28 14:53 ` Frédéric Weisbecker
2009-01-28 14:58 ` Arnaldo Carvalho de Melo
2009-01-29 13:28 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox