From: Rusty Russell <rusty@rustcorp.com.au>
To: David Miller <davem@davemloft.net>
Cc: iws@ovro.caltech.edu, linux-kernel@vger.kernel.org,
markmc@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH] virtio_net: use correct accessors for scatterlists
Date: Wed, 28 Jan 2009 21:29:18 +1030 [thread overview]
Message-ID: <200901282129.19364.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090126.210055.104964648.davem@davemloft.net>
On Tuesday 27 January 2009 15:30:55 David Miller wrote:
> From: Rusty Russell <rusty@rustcorp.com.au>
> Date: Tue, 27 Jan 2009 15:21:19 +1030
>
> > On Saturday 24 January 2009 10:40:53 Ira Snyder wrote:
> > > Without this fix, virtio_net makes incorrect usage of scatterlists. It sets
> > > the end of the scatterlist chain after the first element, despite the fact
> > > that more entries come after it.
> > >
> > > If you try to run dma_map_sg() on one of the scatterlists given to you by
> > > add_buf(), you will get a null pointer oops.
> > >
> > > Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
> >
> > Thanks, this should go in 2.6.29. Dave?
>
> Applied, should I queue it up for -stable too Rusty?
I don't think so. It really is defined as an sg array, not an sg chain. I'm happy to apply a little patch to make Ira's ongoing development easier, but no reason to panic about it.
Thanks,
Rusty.
prev parent reply other threads:[~2009-01-28 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 0:10 [PATCH] virtio_net: use correct accessors for scatterlists Ira Snyder
[not found] ` <200901250010.11434.rusty@rustcorp.com.au>
2009-01-24 18:41 ` Ira Snyder
2009-01-27 4:51 ` Rusty Russell
2009-01-27 5:00 ` David Miller
2009-01-28 10:59 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901282129.19364.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=davem@davemloft.net \
--cc=iws@ovro.caltech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox