Re: mmotm 2009-01-28-02-17 uploaded (i386 build errors: cpusets & kexec)

[Simon Horman <horms@verge.net.au>]

On Wed, Jan 28, 2009 at 04:30:40PM -0800, Andrew Morton wrote:
> On Wed, 28 Jan 2009 08:56:31 -0800
> Randy Dunlap <randy.dunlap@oracle.com> wrote:
> 
> > akpm@linux-foundation.org wrote:
> > > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > > 
> > >    http://userweb.kernel.org/~akpm/mmotm/
> > > 
> > > and will soon be available at
> > > 
> > >    git://git.zen-sources.org/zen/mmotm.git
> > 
> > 
> > 10 randconfigs on i386, 1 good build.
> > 
> > The other 9 ended with either of these build errors:
> > 

[snip]

> So does that.
> 
> --- a/kernel/printk.c~kexec-add-dmesg-log-symbols-to-proc-vmcoreinfo-lists-fix-fix
> +++ a/kernel/printk.c
> @@ -137,11 +137,13 @@ static char *log_buf = __log_buf;
>  static int log_buf_len = __LOG_BUF_LEN;
>  static unsigned logged_chars; /* Number of chars produced since last read+clear operation */
>  
> +#ifdef CONFIG_KEXEC
>  void log_buf_kexec_setup(void)
>  {
>  	VMCOREINFO_SYMBOL(log_buf);
>  	VMCOREINFO_SYMBOL(log_end);
>  }
> +#endif
>  
>  static int __init log_buf_len_setup(char *str)
>  {
> _

Weird, I thought I checked that just now. In any case this email
was already in my inbox. In any case, I can now produce the problem,
and this patch resolves it.

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en