public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <compudj@krystal.dyndns.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: ltt-dev@lists.casi.polymtl.ca, linux-kernel@vger.kernel.org
Subject: Re: [ltt-dev] LTTng 0.87 improved page fault tracing
Date: Wed, 28 Jan 2009 23:43:56 -0500	[thread overview]
Message-ID: <20090129044356.GA26018@Krystal> (raw)
In-Reply-To: <20090129123827.A959.KOSAKI.MOTOHIRO@jp.fujitsu.com>

* KOSAKI Motohiro (kosaki.motohiro@jp.fujitsu.com) wrote:
> Hi
> 
> interesting..
> 
> > I just combined the 4 page fault handler events that were in the tracing
> > hot path of LTTng into 2 :
> > 
> > kernel page_fault_entry
> > kernel page_fault_exit
> > 
> > They take as parameter the combination of what was available in the
> > trap_entry/exit events and handle_mm_fault entry/exit events. This
> > should lessen the performance impact of the tracer when it's active.
> > I did the related modifications in LTTV 0.12.8.
> 
> Just question.
> 
> As far as I know, customer has two different requeremtn of the page fault.

    1 a)
>   (1) collect number of all page fault
>       -> if it is too large, too many interrupt decrease performance.
        (a single event is required for this)

    1 b) the user may also want to know the time spent in the page fault
    handler to service those faults, therefore involving page fault
    entry and exit events.


>   (2) collect number of major page fault
>       -> major page fault indicate to increase random access I/O,
>          then, some customer want to collect major page fault
>          (don't include minor page fault)

Yes, the trace_page_fault_exit takes the "fault" parameter returned by
handle_mm_fault (which is recorded to the trace as the "res" event
field). Using

res & VM_FAULT_MAJOR

will give only the major page faults. Note that some knowledge of the
bitmask is required to interpret the "res" bitfield. This could be done
by a specific analysis module. I would ideally like to create a LTTng
module to export tables including those bitfields so we can keep the
bitfield interpretation in sync with the kernel code changes more or
less automatically.

> 
> Is this patch fill (2) requirement?
> 

Yes.

Mathieu

> 
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

  reply	other threads:[~2009-01-29  4:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-27 21:02 LTTng 0.87 improved page fault tracing Mathieu Desnoyers
2009-01-29  3:42 ` [ltt-dev] " KOSAKI Motohiro
2009-01-29  4:43   ` Mathieu Desnoyers [this message]
2009-01-29  4:47     ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090129044356.GA26018@Krystal \
    --to=compudj@krystal.dyndns.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltt-dev@lists.casi.polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox