From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
hpa@zytor.com, serue@us.ibm.com,
"David C. Hansen" <haveblue@us.ibm.com>,
Containers <containers@lists.osdl.org>,
linux-kernel@vger.kernel.org, sukadev@us.ibm.com
Subject: [RFC][PATCH 0/5] Simplify devpts code
Date: Wed, 28 Jan 2009 22:42:59 -0800 [thread overview]
Message-ID: <20090129064259.GA23160@us.ibm.com> (raw)
This patchset tries to address Christoph Hellwig's review comments on the
support for multiple-instances in devpts. http://lkml.org/lkml/2009/1/3/84
It breaks up the patch into smaller pieces for (hopefully) easier review.
IIUC, the key observation was that most of do_remount_sb() (MS_RDONLY flag
and shrink_dcache() does not apply to devpts and only the parsing of
options does. Moving the parsing code into devpts enables us to parse
the options just once and vastly simplifies the code.
This patchset does not change any functionality/behavior. But it does
depend on following two related patches.
http://lkml.org/lkml/2009/1/29/10
http://lkml.org/lkml/2009/1/29/11
Patches in this set:
[PATCH 1/5] Unroll essentials of do_remount_sb() into devpts
[PATCH 2/5] Parse mount options just once and copy them to super block
[PATCH 3/5] Move common mknod_ptmx() calls into caller
[PATCH 4/5] Remove get_init_pts_sb()
[PATCH 5/5] Merge code for single and multiple-instance mounts
Touch tested. Bisect safe. Needs more testing.
TODO: (possibly as a separate patch ?)
- Merge CONFIG_DEVPTS_MULTIPLE_INSTANCES token with other container-
related tokens ?
next reply other threads:[~2009-01-29 6:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 6:42 Sukadev Bhattiprolu [this message]
2009-01-29 6:45 ` [RFC][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts Sukadev Bhattiprolu
2009-02-01 16:34 ` Christoph Hellwig
2009-01-29 6:46 ` [RFC][PATCH 2/5] Parse mount options just once and copy them to super block Sukadev Bhattiprolu
2009-02-01 16:35 ` Christoph Hellwig
2009-01-29 6:46 ` [RFC][PATCH 3/5] Move common mknod_ptmx() calls into caller Sukadev Bhattiprolu
2009-02-01 16:36 ` Christoph Hellwig
2009-01-29 6:47 ` [RFC][PATCH 4/5] Remove get_init_pts_sb() Sukadev Bhattiprolu
2009-02-01 16:37 ` Christoph Hellwig
2009-01-29 6:47 ` [RFC][PATCH 5/5] Merge code for single and multiple-instance mounts Sukadev Bhattiprolu
2009-02-01 16:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129064259.GA23160@us.ibm.com \
--to=sukadev@linux.vnet.ibm.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=containers@lists.osdl.org \
--cc=haveblue@us.ibm.com \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox