From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756957AbZA2GrS (ORCPT ); Thu, 29 Jan 2009 01:47:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751782AbZA2GrG (ORCPT ); Thu, 29 Jan 2009 01:47:06 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]:50249 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768AbZA2GrF (ORCPT ); Thu, 29 Jan 2009 01:47:05 -0500 Date: Wed, 28 Jan 2009 22:42:59 -0800 From: Sukadev Bhattiprolu To: Christoph Hellwig Cc: Alan Cox , hpa@zytor.com, serue@us.ibm.com, "David C. Hansen" , Containers , linux-kernel@vger.kernel.org, sukadev@us.ibm.com Subject: [RFC][PATCH 0/5] Simplify devpts code Message-ID: <20090129064259.GA23160@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchset tries to address Christoph Hellwig's review comments on the support for multiple-instances in devpts. http://lkml.org/lkml/2009/1/3/84 It breaks up the patch into smaller pieces for (hopefully) easier review. IIUC, the key observation was that most of do_remount_sb() (MS_RDONLY flag and shrink_dcache() does not apply to devpts and only the parsing of options does. Moving the parsing code into devpts enables us to parse the options just once and vastly simplifies the code. This patchset does not change any functionality/behavior. But it does depend on following two related patches. http://lkml.org/lkml/2009/1/29/10 http://lkml.org/lkml/2009/1/29/11 Patches in this set: [PATCH 1/5] Unroll essentials of do_remount_sb() into devpts [PATCH 2/5] Parse mount options just once and copy them to super block [PATCH 3/5] Move common mknod_ptmx() calls into caller [PATCH 4/5] Remove get_init_pts_sb() [PATCH 5/5] Merge code for single and multiple-instance mounts Touch tested. Bisect safe. Needs more testing. TODO: (possibly as a separate patch ?) - Merge CONFIG_DEVPTS_MULTIPLE_INSTANCES token with other container- related tokens ?