Re: [PATCH D 11/11] Fix omap1 clock issues

Russell King - ARM Linux
2009-02-06T21:45:21Z

On Fri, Feb 06, 2009 at 02:19:34PM -0700, Paul Walmsley wrote:
> [paul@pwsan.com: This patch has been updated to use offsets for OMAP1
> clock enable registers, to resolve all current sparse warnings with the
> clock code, and to convert most magic constants into symbolic macros.

Wish you hadn't; I've been avoiding the patches changing the way registers
are accessed for the time being - until I have an opportunity to think
about them for a bit.

As can be seen in the OMAP2 updates, this approach causes additional
struct clk's to appear for mcbsp clocks because they have controlling
registers split across two subsystems. This is contary to one of your
other statements about wanting the struct clk's to reflect the real
clock structure without virtual clocks.