From: Ingo Molnar <mingo@elte.hu>
To: Alexander van Heukelum <heukelum@fastmail.fm>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] x86: trampoline_64.S - use predefined constants with simplification
Date: Thu, 29 Jan 2009 14:36:36 +0100 [thread overview]
Message-ID: <20090129133636.GF24391@elte.hu> (raw)
In-Reply-To: <1233179577.19086.1297291037@webmail.messagingengine.com>
* Alexander van Heukelum <heukelum@fastmail.fm> wrote:
> On Wed, 28 Jan 2009 23:21:25 +0300, "Cyrill Gorcunov"
> <gorcunov@gmail.com> said:
> > Impact: cleanup
> >
> > We may use macros from processor-flags.h instead
> > of hardcoding bits. Actually it's not direct mapping
> > of old instructions with new ones -- BTS does change
> > CF flag while MOV does not. But i didn't find any
> > dependency on CF in this code.
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> > ---
> >
> > Please review
>
> Looks good.
>
> Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>
applied to tip/x86/asm, thanks guys!
Ingo
prev parent reply other threads:[~2009-01-29 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 20:21 [PATCH -tip] x86: trampoline_64.S - use predefined constants with simplification Cyrill Gorcunov
2009-01-28 21:52 ` Alexander van Heukelum
2009-01-29 13:36 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129133636.GF24391@elte.hu \
--to=mingo@elte.hu \
--cc=gorcunov@gmail.com \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox