Re: [PATCH -tip] x86: trampoline_64.S - use predefined constants with simplification

Ingo Molnar
2009-01-29T13:36:52Z

* Alexander van Heukelum <heukelum@fastmail.fm> wrote:

> On Wed, 28 Jan 2009 23:21:25 +0300, "Cyrill Gorcunov"
> <gorcunov@gmail.com> said:
> > Impact: cleanup
> >
> > We may use macros from processor-flags.h instead
> > of hardcoding bits. Actually it's not direct mapping
> > of old instructions with new ones -- BTS does change
> > CF flag while MOV does not. But i didn't find any
> > dependency on CF in this code.
> >
> > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
> > ---
> >
> > Please review
>
> Looks good.
>
> Acked-by: Alexander van Heukelum <heukelum@fastmail.fm>

applied to tip/x86/asm, thanks guys!

Ingo