From: Ingo Molnar <mingo@elte.hu>
To: Jack Steiner <steiner@sgi.com>
Cc: suresh.b.siddha@intel.com, linux-kernel@vger.kernel.org
Subject: Re: Possible x2apic breakage
Date: Thu, 29 Jan 2009 17:15:46 +0100 [thread overview]
Message-ID: <20090129161546.GB28984@elte.hu> (raw)
In-Reply-To: <20090129154146.GA2694@sgi.com>
* Jack Steiner <steiner@sgi.com> wrote:
> Suresh -
>
> This popped up in Ingo's x86 tree yesterday. This appears to be breaking
> on our simulator running in x2apic mode. If I understand the code,
> this is a real breakage and not a problem in our simulator:
>
>
> arch/x86/include/asm/genapic.h
>
> static inline unsigned int read_apic_id(void)
> {
> unsigned int reg;
>
> reg = *(u32 *)(APIC_BASE + APIC_ID);
> return apic->get_apic_id(reg);
> }
>
>
> As expected, the failure occurs right after:
>
> Enabling x2apic
> Enabled x2apic and interrupt-remapping
>
> The next reference to apicid tries to read from mem instead of MSRs.
yes - Suresh sent a fix earlier today. Could you please check latest
tip/master (v2.6.29-rc3-1212-g69f3c6d or later), does it work fine in your
simulator?
And i'll also merge struct apic_ops into struct genapic - now that genapic
is unified there's no reason for the two to be separate.
Ingo
next prev parent reply other threads:[~2009-01-29 16:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 15:41 Possible x2apic breakage Jack Steiner
2009-01-29 16:15 ` Ingo Molnar [this message]
2009-01-29 20:03 ` Jack Steiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129161546.GB28984@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=steiner@sgi.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox