From: Andrew Morton <akpm@linux-foundation.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: rostedt@goodmis.org, mingo@elte.hu, linux-kernel@vger.kernel.org,
acme@ghostprotocols.net, fweisbec@gmail.com
Subject: Re: [PATCH] tracing/ftrace: add an option to not print the context info for events
Date: Thu, 29 Jan 2009 16:19:56 -0800 [thread overview]
Message-ID: <20090129161956.9158e9c6.akpm@linux-foundation.org> (raw)
In-Reply-To: <497671d4.1358560a.7a83.6114@mx.google.com>
On Tue, 20 Jan 2009 16:52:36 -0800 (PST)
Frederic Weisbecker <fweisbec@gmail.com> wrote:
> + usec_rem = do_div(t, 1000000ULL);
The second argument to do_div() is in fact a u32. It's quite hard to
track this down due to use of macros and lack of comemnts.
Doing
usec_rem = do_div(t, USEC_PER_SEC);
would suit here.
next prev parent reply other threads:[~2009-01-30 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 0:52 [PATCH] tracing/ftrace: add an option to not print the context info for events Frederic Weisbecker
2009-01-21 2:55 ` Steven Rostedt
2009-01-21 9:02 ` Frederic Weisbecker
2009-01-25 16:24 ` Frederic Weisbecker
2009-01-30 0:19 ` Andrew Morton [this message]
2009-01-30 0:38 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129161956.9158e9c6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox