From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
To: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested ssc instance is not found
Date: Thu, 29 Jan 2009 17:46:55 +0100 [thread overview]
Message-ID: <20090129174655.1f440f3e@hcegtvedt> (raw)
In-Reply-To: <1232369876-19428-1-git-send-email-hans-christian.egtvedt@atmel.com>
On Mon, 19 Jan 2009 13:57:56 +0100
Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> wrote:
Bump, or did I miss the merge window?
> This patch replaces the dev_dbg(...) with a pr_err since the ssc
> pointer is not valid when the id is not found in the list.
>
> Signed-off-by: Hans-Christian Egtvedt
> <hans-christian.egtvedt@atmel.com> ---
> drivers/misc/atmel-ssc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
> index 6b35874..6cff1bb 100644
> --- a/drivers/misc/atmel-ssc.c
> +++ b/drivers/misc/atmel-ssc.c
> @@ -35,7 +35,7 @@ struct ssc_device *ssc_request(unsigned int ssc_num)
>
> if (!ssc_valid) {
> spin_unlock(&user_lock);
> - dev_dbg(&ssc->pdev->dev, "could not find requested device\n");
> + pr_err("ssc: ssc%d platform device is missing\n", ssc_num);
> return ERR_PTR(-ENODEV);
> }
>
--
Best regards,
Hans-Christian Egtvedt
next prev parent reply other threads:[~2009-01-29 16:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 12:57 [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested ssc instance is not found Hans-Christian Egtvedt
2009-01-29 16:46 ` Hans-Christian Egtvedt [this message]
2009-01-29 23:50 ` Andrew Morton
2009-01-30 8:20 ` Hans-Christian Egtvedt
2009-01-30 8:35 ` Andrew Morton
2009-01-30 9:26 ` Haavard Skinnemoen
2009-01-30 9:36 ` Andrew Morton
2009-01-30 9:50 ` Hans-Christian Egtvedt
2009-01-30 12:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129174655.1f440f3e@hcegtvedt \
--to=hans-christian.egtvedt@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox