From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: allow 8 more cpus could be used
Date: Fri, 30 Jan 2009 00:08:27 +0100 [thread overview]
Message-ID: <20090129230827.GA29611@elte.hu> (raw)
In-Reply-To: <4982315F.20705@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
> Ingo Molnar wrote:
> > * Yinghai Lu <yinghai@kernel.org> wrote:
> >
> >> Impact: fix left out MARCO
> >>
> >> X86_PC will be always enabled. so need to check if we have bigsmp
> >> support built in before cut off more than 8 cpus.
> >
> > ah, that's a leftover reference to X86_PC. It can now be removed, together
> > with the Kconfig X86_PC option.
> >
> >> -#if defined(CONFIG_X86_PC) && defined(CONFIG_X86_32)
> >> +#if defined(CONFIG_X86_PC) && !defined(CONFIG_X86_BIGSMP)
> >> if (def_to_bigsmp && nr_cpu_ids > 8) {
> >> unsigned int cpu;
> >> unsigned nr;
> >
> > Could you please send a patch that removes both X86_PC and X86_BIGSMP -
> > and removes the above cutoff code too, so that it will be built-in all the
> > time?
>
> sure. maybe we could keep X86_BIGSMP for a while. So someone don't
> enable BIGSMP for small system?
yeah, we can certainly keep it - the code to conditionalize it is there
and isnt causing problems really.
Ingo
next prev parent reply other threads:[~2009-01-29 23:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 22:18 [PATCH] x86: allow 8 more cpus could be used Yinghai Lu
2009-01-29 22:19 ` [PATCH] x86: don't treat bigsmp as no standard Yinghai Lu
2009-01-30 14:25 ` Ingo Molnar
2009-01-29 22:42 ` [PATCH] x86: allow 8 more cpus could be used Ingo Molnar
2009-01-29 22:44 ` Yinghai Lu
2009-01-29 23:08 ` Ingo Molnar [this message]
2009-01-29 23:14 ` Yinghai Lu
2009-01-29 23:20 ` Ingo Molnar
2009-01-29 22:44 ` Randy Dunlap
2009-01-29 23:12 ` Ingo Molnar
2009-01-29 23:14 ` Randy Dunlap
2009-01-29 23:22 ` Ingo Molnar
2009-01-29 23:23 ` Yinghai Lu
2009-01-29 23:25 ` Randy Dunlap
2009-01-30 0:09 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129230827.GA29611@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox