Re: [PATCH -next/mmotm/resend] kmemtrace: fix printk formats

[Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>]

On Thu, Jan 29, 2009 at 01:49:45PM -0800, Randy Dunlap wrote:
> Geert Uytterhoeven wrote:
> > 
> > %4zu?
> 
> Ugh, yes.  Thanks.
> Here's the updated patch.
> 
> -- 
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix kmemtrace printk warnings:
> 
> kernel/trace/kmemtrace.c:142: warning: format '%4ld' expects type 'long int', but argument 3 has type 'size_t'
> kernel/trace/kmemtrace.c:147: warning: format '%4ld' expects type 'long int', but argument 3 has type 'size_t'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc:      Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
> ---
>  kernel/trace/kmemtrace.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-next-20090123.orig/kernel/trace/kmemtrace.c
> +++ linux-next-20090123/kernel/trace/kmemtrace.c
> @@ -139,12 +139,12 @@ kmemtrace_print_alloc_compress(struct tr
>  		return TRACE_TYPE_PARTIAL_LINE;
>  
>  	/* Requested */
> -	ret = trace_seq_printf(s, "%4ld   ", entry->bytes_req);
> +	ret = trace_seq_printf(s, "%4zu   ", entry->bytes_req);
>  	if (!ret)
>  		return TRACE_TYPE_PARTIAL_LINE;
>  
>  	/* Allocated */
> -	ret = trace_seq_printf(s, "%4ld   ", entry->bytes_alloc);
> +	ret = trace_seq_printf(s, "%4zu   ", entry->bytes_alloc);
>  	if (!ret)
>  		return TRACE_TYPE_PARTIAL_LINE;
>

I didn't notice this either, thanks.

Acked-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>


	Eduard