From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>,
Haavard Skinnemoen <hskinnemoen@atmel.com>,
Huang Weiyi <weiyi.huang@gmail.com>
Subject: Re: [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested ssc instance is not found
Date: Fri, 30 Jan 2009 09:20:25 +0100 [thread overview]
Message-ID: <20090130092025.618fa78f@hcegtvedt> (raw)
In-Reply-To: <20090129155042.e0ea148d.akpm@linux-foundation.org>
On Thu, 29 Jan 2009 15:50:42 -0800
Andrew Morton <akpm@linux-foundation.org> wrote:
> On Thu, 29 Jan 2009 17:46:55 +0100
> Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> wrote:
>
<snipp>
> > Bump, or did I miss the merge window?
> >
>
> (Top-posting repaired. Please don't do that! It makes it horrid to
> reply to you)
>
Sorry, I'll do a resend of the original email instead next time. I had
the idea about the initial email would be picked up.
> (Suitable cc's added - this was why your patch got lost)
>
AFAICT the lkml is the place for the drivers/misc stuff. Should I be
looking in another file than MAINTAINERS?
> The patch seems reasonable but the changelog seems to be quite
> misleading. I did this:
>
> The ssc pointer is not valid when the id is not found in the
> list. Convert the message from a debug one into an error message
> and avoid dereferencing the bad pointer.
>
> OK?
Sounds way better than my Norwegian English, thanks (-:
--
Best regards,
Hans-Christian Egtvedt
next prev parent reply other threads:[~2009-01-30 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 12:57 [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested ssc instance is not found Hans-Christian Egtvedt
2009-01-29 16:46 ` Hans-Christian Egtvedt
2009-01-29 23:50 ` Andrew Morton
2009-01-30 8:20 ` Hans-Christian Egtvedt [this message]
2009-01-30 8:35 ` Andrew Morton
2009-01-30 9:26 ` Haavard Skinnemoen
2009-01-30 9:36 ` Andrew Morton
2009-01-30 9:50 ` Hans-Christian Egtvedt
2009-01-30 12:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090130092025.618fa78f@hcegtvedt \
--to=hans-christian.egtvedt@atmel.com \
--cc=akpm@linux-foundation.org \
--cc=hskinnemoen@atmel.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyi.huang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox