From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754728AbZA3LZT (ORCPT ); Fri, 30 Jan 2009 06:25:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752316AbZA3LZB (ORCPT ); Fri, 30 Jan 2009 06:25:01 -0500 Received: from brick.kernel.dk ([93.163.65.50]:10156 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbZA3LZA (ORCPT ); Fri, 30 Jan 2009 06:25:00 -0500 Date: Fri, 30 Jan 2009 12:23:11 +0100 From: Jens Axboe To: Peter Zijlstra Cc: Linus Torvalds , Steven Rostedt , Andrew Morton , LKML , Rusty Russell , npiggin@suse.de, Ingo Molnar , Thomas Gleixner , Arjan van de Ven Subject: Re: [PATCH -v2] use per cpu data for single cpu ipi calls Message-ID: <20090130112310.GI30821@kernel.dk> References: <20090128173039.cbc29e81.akpm@linux-foundation.org> <1233218954.7835.11.camel@twins> <1233253380.4495.123.camel@laptop> <1233254680.4495.126.camel@laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1233254680.4495.126.camel@laptop> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, A little late into this discussion, was nasty ill the past days. Anyway, v2 with the suggested patches looks fine to me. That is, use local cpu storage (and thus lose the lock) and retain the the kmalloc() for the !wait case. That should still scale fine, as far as I can tell. The block layer usage, for which this was originally concocted, doesn't really care that much, since it always provides its own csd storage and thus use the __ variant of the helper. Peter, can you post a final complete patch for review and acks? -- Jens Axboe