From: Mark Brown <broonie@sirena.org.uk>
To: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net,
kay.sievers@vrfy.org, weiyi.huang@gmail.com,
Andrew Victor <avictor.za@gmail.com>
Subject: Re: [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested ssc instance is not found
Date: Fri, 30 Jan 2009 12:54:08 +0000 [thread overview]
Message-ID: <20090130125408.GE18825@sirena.org.uk> (raw)
In-Reply-To: <20090130105057.7d0acaec@hcegtvedt>
On Fri, Jan 30, 2009 at 10:50:57AM +0100, Hans-Christian Egtvedt wrote:
> 1 sound/soc/atmel/sam9g20_wm8731.c 274 ssc = ssc_request(0);
> 2 sound/soc/atmel/playpaq_wm8510.c 399 ssc = ssc_request(0);
> 3 sound/spi/at73c213.c 980 chip->ssc = ssc_request(board->ssc_id);
> The two first are a bit suspicious since they hard code id 0.
They are ASoC board drivers so are already entirely specific to one
board (or family of boards).
prev parent reply other threads:[~2009-01-30 13:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 12:57 [PATCH 1/1] atmel-ssc: fix misuse of dev_dbg when requested ssc instance is not found Hans-Christian Egtvedt
2009-01-29 16:46 ` Hans-Christian Egtvedt
2009-01-29 23:50 ` Andrew Morton
2009-01-30 8:20 ` Hans-Christian Egtvedt
2009-01-30 8:35 ` Andrew Morton
2009-01-30 9:26 ` Haavard Skinnemoen
2009-01-30 9:36 ` Andrew Morton
2009-01-30 9:50 ` Hans-Christian Egtvedt
2009-01-30 12:54 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090130125408.GE18825@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=akpm@linux-foundation.org \
--cc=avictor.za@gmail.com \
--cc=dbrownell@users.sourceforge.net \
--cc=haavard.skinnemoen@atmel.com \
--cc=hans-christian.egtvedt@atmel.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyi.huang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox