Re: [PATCH] voyager: fix up for moving the generic smp call func to pointers

[Ingo Molnar <mingo@elte.hu>]

* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:

> On Fri, 2009-01-30 at 19:54 +0100, Ingo Molnar wrote:
> > James,
> > 
> > * James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> > 
> > > commit e7986739a76cde5079da08809d8bbc6878387ae0
> > > Author: Mike Travis <travis@sgi.com>
> > > Date:   Tue Dec 16 17:33:52 2008 -0800
> > > 
> > >     x86 smp: modify send_IPI_mask interface to accept cpumask_t pointers
> > > 
> > > Changed all the IPI ops to take pointers, but didn't update voyager,
> > > which is now broken.  Make the changes in voyager as well.
> > 
> > Note: earlier this week i've rearchitectured the x86 subarchitecture and 
> > APIC code - so there's a whole lot more to be done on the Voyager side 
> > than just the cpumask conversion.
> 
> Not for 2.6.29 there isn't.
> 
> > The x86/Voyager subarch is not fully ported yet (i cleaned up its Kconfig 
> > impact already) and hence it is disabled for the time being. It ought to 
> > be relatively straightforward to port it to the new code - if you are 
> > interested in doing that.
> > 
> > You can find the latest code in tip/master at:
> > 
> >    http://people.redhat.com/mingo/tip.git/README
> > 
> > it's tentatively aimed for v2.6.30.
> 
> Right, and I'll fix the rest for 2.6.30. [...]

ok.

> [...] However, this patch is needed now to get 2.6.29-rc3 to boot.

and there's also the other ones. We can put them in now that we've got the 
new subarch code. Could you send a pull request with all the voyager fixes 
collected into one tree?

	Ingo