Re: [PATCH] kbuild: drop check for CONFIG_ in headers_check

Arnd Bergmann
2009-01-31T00:27:49Z

On Saturday 31 January 2009, Ingo Molnar wrote:
> Jaswinder, i think we now have a realistic chance to reach a zero baseline
> with these warnings, for v2.6.29. Here are the remaining warnings (summed
> up per file) on x86 (after Sam's patch):
>
>      17 /dev/shm/tip/usr/include/linux/reiserfs_fs.h
>      12 /dev/shm/tip/usr/include/linux/soundcard.h
>       3 /dev/shm/tip/usr/include/linux/nubus.h
>       2 /dev/shm/tip/usr/include/linux/in6.h
>       1 /dev/shm/tip/usr/include/mtd/jffs2-user.h
>       1 /dev/shm/tip/usr/include/linux/socket.h
>       1 /dev/shm/tip/usr/include/linux/coda_psdev.h
>       1 /dev/shm/tip/usr/include/linux/bsg.h
>

Ah, that doesn't look too bad. On a related subject, was there ever a
conclusion about whether we want to support __KERNEL_STRICT_NAMES in
every header? When that is set, headers cannot use most of the standard
types (dev_t, mode_t, off_t, pid_t, suseconds_t, timer_t, uid_t, gid_t,
loff_t, time_t, clock_t, caddr_t, pgoff_t, {u_,u,}int{8,16,32,64}_6})
but have to use the __kernel_* versions of that.

It doesn't seem hard to fix, but I'm not sure if it needs to be touched.
If we decide to fix it, it's easy enough to do during headers_install,
or once for the whole tree. The __kernel_* types need this patch:

asm-generic/fcntl.h | 12 ++++++------
asm-generic/siginfo.h | 14 +++++++-------
linux/agpgart.h | 14 +++++++-------
linux/cn_proc.h | 20 ++++++++++----------
linux/cyclades.h | 6 +++---
linux/dvb/video.h | 2 +-
linux/if_pppol2tp.h | 2 +-
linux/mroute6.h | 2 +-
linux/netfilter_ipv4/ipt_owner.h | 8 ++++----
linux/netfilter_ipv6/ip6t_owner.h | 8 ++++----
linux/ppp_defs.h | 4 ++--
linux/suspend_ioctls.h | 4 ++--
linux/xfrm.h | 2 +-
mtd/mtd-abi.h | 4 ++--
sound/asound.h | 4 ++--
14 files changed, 52 insertions(+), 52 deletions(-)

The int types are a lot more:
drm/drm.h | 18 ++--
drm/drm_mode.h | 148 ++++++++++++++--------------
drm/i915_drm.h | 138 +++++++++++++-------------
drm/mga_drm.h | 16 ++--
drm/radeon_drm.h | 2 +-
drm/via_drm.h | 40 ++++----
linux/atmlec.h | 4 +-
linux/atmmpc.h | 44 +++++-----
linux/cm4000_cs.h | 8 +-
linux/dlm_netlink.h | 16 ++--
linux/dm-ioctl.h | 42 ++++----
linux/dvb/audio.h | 2 +-
linux/dvb/video.h | 22 ++--
linux/if_arcnet.h | 26 +++---
linux/ip_vs.h | 26 +++---
linux/ivtvfb.h | 2 +-
linux/jffs2.h | 26 +++---
linux/matroxfb.h | 2 +-
linux/pfkeyv2.h | 242 +++++++++++++++++++++++-----------------------
linux/selinux_netlink.h | 4 +-
linux/suspend_ioctls.h | 2 +-
mtd/inftl-user.h | 36 ++++----
mtd/jffs2-user.h | 4 +-
mtd/mtd-abi.h | 64 ++++++------
mtd/nftl-user.h | 30 +++---
mtd/ubi-user.h | 70 +++++++-------
sound/asound.h | 2 +-
sound/emu10k1.h | 8 +-
29 files changed, 523 insertions(+), 523 deletions(-)