From: Myron Stowe <myron.stowe@hp.com>
To: lenb@kernel.org
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
myron.stowe@hp.com
Subject: [PATCH 0/2] ACPICA: Fix truncation message calculation
Date: Fri, 30 Jan 2009 15:44:48 -0700 [thread overview]
Message-ID: <20090130223832.24329.5434.stgit@bob.kio> (raw)
Len:
The following two item patch series fixes a calculation in
./drivers/acpi/tables/tbutils.c::acpi_tb_parse_root_table() that
determines how many ACPI table entries will be truncated when the
number of RSDT/XSDT entries is greater than the statically allocated
'initial_tables[]' array.
As currently implemented, the calculation will always yield a value
of 0. The following output shows the issue (Note the line with
"...: Truncating ..." which incorrectly indicates 0):
ACPI: RSDP 32A82014, 0024 (r2 HP )
ACPI: XSDT 32A82580, 0494 (r1 HP XXXXXX 0 1000013)
ACPI Error (tbinstal-0207): Resize of Root Table Array is not allowed [20070126]
ACPI Warning (tbutils-0519): Truncating 0 table entries! [20070126]
ACPI: FACP 32A6C000, 00F4 (r3 HP XXXXXX 0 HP 0)
ACPI: DSDT 32A52000, 8E83 (r2 HP XXXXXX 8 INTL 20061109)
...
With the patch applied, the output correctly shows the number of
(missing) truncated entries:
ACPI: RSDP 32A82014, 0024 (r2 HP )
ACPI: XSDT 32A82580, 0494 (r1 HP XXXXXX 0 1000013)
ACPI Error (tbinstal-0207): Resize of Root Table Array is not allowed [20070126]
ACPI Warning (tbutils-0519): Truncating 5 table entries! [20070126]
ACPI: FACP 32A6C000, 00F4 (r3 HP XXXXXX 0 HP 0)
ACPI: DSDT 32A52000, 8E83 (r2 HP XXXXXX 8 INTL 20061109)
...
[PATCH 1/2] fixes the truncation message related calculation.
[PATCH 2/2] is non-functional white space fixes - 80 column adherence -
for the same file.
The underlying code affected is common to both x86 and ia64. I have
tested the patch on an ia64 platform.
All comments welcome.
Myron
---
Myron Stowe (2):
ACPICA: 80 column adherence (no functional change)
ACPICA: Fix table entry truncation calculation
drivers/acpi/acpica/tbutils.c | 43 +++++++++++++++++++++++++++--------------
1 files changed, 28 insertions(+), 15 deletions(-)
next reply other threads:[~2009-01-30 22:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 22:44 Myron Stowe [this message]
2009-01-30 22:44 ` [PATCH 1/2] ACPICA: Fix table entry truncation calculation Myron Stowe
2009-01-30 22:44 ` [PATCH 2/2] ACPICA: 80 column adherence (no functional change) Myron Stowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090130223832.24329.5434.stgit@bob.kio \
--to=myron.stowe@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox