From: Dan Williams <dan.j.williams@intel.com>
To: hskinnemoen@atmel.com
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
kernel@avr32linux.org, linux-kernel@vger.kernel.org
Subject: [PATCH] atmel-mci: fix initialization of dma slave data
Date: Fri, 30 Jan 2009 16:05:57 -0700 [thread overview]
Message-ID: <20090130230248.2402.65405.stgit@dwillia2-linux.ch.intel.com> (raw)
The conversion of atmel-mci to dma_request_channel missed the initialization
of the channel dma_slave information. dma_request_channel, along with the
filter_fn, find the channel with the proper capabilities, then it is up to the
driver to update the dw_dma_chan with its slave data.
Reported-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
Haavard,
I do not have any conflicting dmaengine patches so feel free to carry
this through the avr32 tree.
Regards,
Dan
drivers/dma/dw_dmac_regs.h | 24 ------------------------
drivers/mmc/host/atmel-mci.c | 1 +
include/linux/dw_dmac.h | 33 +++++++++++++++++++++++++++++++++
3 files changed, 34 insertions(+), 24 deletions(-)
diff --git a/drivers/dma/dw_dmac_regs.h b/drivers/dma/dw_dmac_regs.h
index 00fdd18..10ffa5c 100644
--- a/drivers/dma/dw_dmac_regs.h
+++ b/drivers/dma/dw_dmac_regs.h
@@ -126,24 +126,6 @@ struct dw_dma_regs {
#define DW_REGLEN 0x400
-struct dw_dma_chan {
- struct dma_chan chan;
- void __iomem *ch_regs;
- u8 mask;
-
- spinlock_t lock;
-
- /* these other elements are all protected by lock */
- dma_cookie_t completed;
- struct list_head active_list;
- struct list_head queue;
- struct list_head free_list;
-
- struct dw_dma_slave *dws;
-
- unsigned int descs_allocated;
-};
-
static inline struct dw_dma_chan_regs __iomem *
__dwc_regs(struct dw_dma_chan *dwc)
{
@@ -155,12 +137,6 @@ __dwc_regs(struct dw_dma_chan *dwc)
#define channel_writel(dwc, name, val) \
__raw_writel((val), &(__dwc_regs(dwc)->name))
-static inline struct dw_dma_chan *to_dw_dma_chan(struct dma_chan *chan)
-{
- return container_of(chan, struct dw_dma_chan, chan);
-}
-
-
struct dw_dma {
struct dma_device dma;
void __iomem *regs;
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index 76bfe16..2a81d46 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -1618,6 +1618,7 @@ static int __init atmci_probe(struct platform_device *pdev)
dma_cap_zero(mask);
dma_cap_set(DMA_SLAVE, mask);
host->dma.chan = dma_request_channel(mask, filter, dws);
+ set_dw_dma_slave(host->dma.chan, dws);
}
if (!host->dma.chan)
dev_notice(&pdev->dev, "DMA not available, using PIO\n");
diff --git a/include/linux/dw_dmac.h b/include/linux/dw_dmac.h
index d797dde..799b6ef 100644
--- a/include/linux/dw_dmac.h
+++ b/include/linux/dw_dmac.h
@@ -54,6 +54,39 @@ struct dw_dma_slave {
u32 cfg_lo;
};
+struct dw_dma_chan {
+ struct dma_chan chan;
+ void __iomem *ch_regs;
+ u8 mask;
+
+ spinlock_t lock;
+
+ /* these other elements are all protected by lock */
+ dma_cookie_t completed;
+ struct list_head active_list;
+ struct list_head queue;
+ struct list_head free_list;
+
+ struct dw_dma_slave *dws;
+
+ unsigned int descs_allocated;
+};
+
+static inline struct dw_dma_chan *to_dw_dma_chan(struct dma_chan *chan)
+{
+ return container_of(chan, struct dw_dma_chan, chan);
+}
+
+static inline void set_dw_dma_slave(struct dma_chan *chan, struct dw_dma_slave *dws)
+{
+ if (chan) {
+ struct dw_dma_chan *dwc = to_dw_dma_chan(chan);
+
+ dwc->dws = dws;
+ }
+}
+
+
/* Platform-configurable bits in CFG_HI */
#define DWC_CFGH_FCMODE (1 << 0)
#define DWC_CFGH_FIFO_MODE (1 << 1)
next reply other threads:[~2009-01-30 23:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 23:05 Dan Williams [this message]
2009-01-31 12:06 ` [PATCH] atmel-mci: fix initialization of dma slave data Atsushi Nemoto
2009-01-31 14:52 ` Atsushi Nemoto
2009-01-31 16:26 ` Dan Williams
2009-02-02 15:01 ` Hans-Christian Egtvedt
2009-02-02 16:04 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090130230248.2402.65405.stgit@dwillia2-linux.ch.intel.com \
--to=dan.j.williams@intel.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=hskinnemoen@atmel.com \
--cc=kernel@avr32linux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox