Re: mmotm 2009-01-28-02-17 uploaded - docking station issues.

[Andrew Morton <akpm@linux-foundation.org>]

On Sat, 31 Jan 2009 03:40:14 -0500 Valdis.Kletnieks@vt.edu wrote:

> On Fri, 30 Jan 2009 21:03:52 PST, Andrew Morton said:
> > On Thu, 29 Jan 2009 11:25:43 -0500 Valdis.Kletnieks@vt.edu wrote:
> > 
> > > On Wed, 28 Jan 2009 02:19:09 PST, akpm@linux-foundation.org said:
> > > > The mm-of-the-moment snapshot 2009-01-28-02-17 has been uploaded to
> > > >    http://userweb.kernel.org/~akpm/mmotm/
> 
> > > % ls -l /sys/devices/platform/dock.0/docked
> > > -r--r--r-- 1 root root 4096 2009-01-29 10:49 /sys/devices/platform/dock.0/docked
> > > % cat /sys/devices/platform/dock.0/docked
> > > =F1=DEcat: write error: Bad address
> > >
> > > strace of the cat shows:
> > >
> > > open("/sys/devices/platform/dock.0/docked", O_RDONLY) = 3
> > > fstat(3, {st_mode=S_IFREG|0444, st_size=4096, ...}) = 0
> > > read(3, "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0"..., 4096) = 1812586496
> 
> > > Under 2.6.29-rc2-mmotm0116, this would return either "0" or "1", not 4K
> > > of nulls.
> 
> > Is it due to
> >
> > acpi-dock-dont-eval-_sta-on-every-show_docked-sysfs-read.patch
> 
> Bingo. Reverting that patch and the sysfs-read-simplified.patch fixed it.
> 
> So obviously something in there doesn't agree with the innards of my laptop -
> 

urgh,
acpi-dock-dont-eval-_sta-on-every-show_docked-sysfs-read-simplification.patch
is completely wrong (return value) and the insane warning storm which
kernel builds create hid that from me.

I dropped it.