public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Jaswinder Singh Rajput <jaswinder@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	David Miller <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: drop check for CONFIG_ in headers_check
Date: Sat, 31 Jan 2009 01:27:02 +0100	[thread overview]
Message-ID: <200901310127.03142.arnd@arndb.de> (raw)
In-Reply-To: <20090130234012.GF4922@elte.hu>

On Saturday 31 January 2009, Ingo Molnar wrote:
> Jaswinder, i think we now have a realistic chance to reach a zero baseline 
> with these warnings, for v2.6.29. Here are the remaining warnings (summed 
> up per file) on x86 (after Sam's patch):
> 
>      17 /dev/shm/tip/usr/include/linux/reiserfs_fs.h
>      12 /dev/shm/tip/usr/include/linux/soundcard.h
>       3 /dev/shm/tip/usr/include/linux/nubus.h
>       2 /dev/shm/tip/usr/include/linux/in6.h
>       1 /dev/shm/tip/usr/include/mtd/jffs2-user.h
>       1 /dev/shm/tip/usr/include/linux/socket.h
>       1 /dev/shm/tip/usr/include/linux/coda_psdev.h
>       1 /dev/shm/tip/usr/include/linux/bsg.h
> 

Ah, that doesn't look too bad. On a related subject, was there ever a
conclusion about whether we want to support __KERNEL_STRICT_NAMES in
every header? When that is set, headers cannot use most of the standard
types (dev_t, mode_t, off_t, pid_t, suseconds_t, timer_t, uid_t, gid_t,
loff_t, time_t, clock_t, caddr_t, pgoff_t, {u_,u,}int{8,16,32,64}_6})
but have to use the __kernel_* versions of that.

It doesn't seem hard to fix, but I'm not sure if it needs to be touched.
If we decide to fix it, it's easy enough to do during headers_install,
or once for the whole tree. The __kernel_* types need this patch:

 asm-generic/fcntl.h               |   12 ++++++------
 asm-generic/siginfo.h             |   14 +++++++-------
 linux/agpgart.h                   |   14 +++++++-------
 linux/cn_proc.h                   |   20 ++++++++++----------
 linux/cyclades.h                  |    6 +++---
 linux/dvb/video.h                 |    2 +-
 linux/if_pppol2tp.h               |    2 +-
 linux/mroute6.h                   |    2 +-
 linux/netfilter_ipv4/ipt_owner.h  |    8 ++++----
 linux/netfilter_ipv6/ip6t_owner.h |    8 ++++----
 linux/ppp_defs.h                  |    4 ++--
 linux/suspend_ioctls.h            |    4 ++--
 linux/xfrm.h                      |    2 +-
 mtd/mtd-abi.h                     |    4 ++--
 sound/asound.h                    |    4 ++--
 14 files changed, 52 insertions(+), 52 deletions(-)

The int types are a lot more:
 drm/drm.h               |   18 ++--
 drm/drm_mode.h          |  148 ++++++++++++++--------------
 drm/i915_drm.h          |  138 +++++++++++++-------------
 drm/mga_drm.h           |   16 ++--
 drm/radeon_drm.h        |    2 +-
 drm/via_drm.h           |   40 ++++----
 linux/atmlec.h          |    4 +-
 linux/atmmpc.h          |   44 +++++-----
 linux/cm4000_cs.h       |    8 +-
 linux/dlm_netlink.h     |   16 ++--
 linux/dm-ioctl.h        |   42 ++++----
 linux/dvb/audio.h       |    2 +-
 linux/dvb/video.h       |   22 ++--
 linux/if_arcnet.h       |   26 +++---
 linux/ip_vs.h           |   26 +++---
 linux/ivtvfb.h          |    2 +-
 linux/jffs2.h           |   26 +++---
 linux/matroxfb.h        |    2 +-
 linux/pfkeyv2.h         |  242 +++++++++++++++++++++++-----------------------
 linux/selinux_netlink.h |    4 +-
 linux/suspend_ioctls.h  |    2 +-
 mtd/inftl-user.h        |   36 ++++----
 mtd/jffs2-user.h        |    4 +-
 mtd/mtd-abi.h           |   64 ++++++------
 mtd/nftl-user.h         |   30 +++---
 mtd/ubi-user.h          |   70 +++++++-------
 sound/asound.h          |    2 +-
 sound/emu10k1.h         |    8 +-
 29 files changed, 523 insertions(+), 523 deletions(-)

  reply	other threads:[~2009-01-31  0:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-30 19:04 [git pull V2] headers_check fixes Jaswinder Singh Rajput
2009-01-30 19:26 ` Ingo Molnar
2009-01-30 20:40   ` Arnd Bergmann
2009-01-30 22:56   ` [PATCH] kbuild: drop check for CONFIG_ in headers_check Sam Ravnborg
2009-01-30 23:40     ` Ingo Molnar
2009-01-31  0:27       ` Arnd Bergmann [this message]
2009-01-31  0:41         ` Ingo Molnar
2009-01-31  1:06           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901310127.03142.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox