public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	Jaswinder Singh Rajput <jaswinder@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	David Miller <davem@davemloft.net>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: drop check for CONFIG_ in headers_check
Date: Sat, 31 Jan 2009 02:06:40 +0100	[thread overview]
Message-ID: <200901310206.41053.arnd@arndb.de> (raw)
In-Reply-To: <20090131004111.GB13709@elte.hu>

On Saturday 31 January 2009, Ingo Molnar wrote:
> hm, that looks quite ugly and unnatural. Could the usr/* exporting scripts 
> convert these types automatically to the __kernel_* versions?

It's possible, but there are some minor complications, e.g. linux/coda.h has
its own magic code that would likely break in the process, so it needs
to be skipped. Some other files conditionally include <sys/types.h> or
<stdint.h> in user space and would break in a similar way.

For the __kernel_ types, we have 87 instances in the tree, and 53 more that
would have to change. For the int types, there are over 4000 instances
of the correct __u32 style and about 800 that use the u_int32_t or
uint32_t style, most of them in netfilter and linux/pfkeyv2.h.

I'd probably leave at least the drm, netfilter and mtd headers alone,
as they are known to be working and consistently use the stdint.h types.

	Arnd <><

      reply	other threads:[~2009-01-31  1:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-30 19:04 [git pull V2] headers_check fixes Jaswinder Singh Rajput
2009-01-30 19:26 ` Ingo Molnar
2009-01-30 20:40   ` Arnd Bergmann
2009-01-30 22:56   ` [PATCH] kbuild: drop check for CONFIG_ in headers_check Sam Ravnborg
2009-01-30 23:40     ` Ingo Molnar
2009-01-31  0:27       ` Arnd Bergmann
2009-01-31  0:41         ` Ingo Molnar
2009-01-31  1:06           ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901310206.41053.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jaswinder@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox