public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>, Willy Tarreau <w@1wt.eu>,
	Rodrigo Rubira Branco <rbranco@la.checkpoint.com>,
	Jake Edge <jake@lwn.net>, Eugene Teo <eteo@redhat.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, Miklos Szeredi <mszeredi@suse.cz>
Subject: [patch 01/32] fuse: destroy bdi on umount
Date: Fri, 30 Jan 2009 18:39:25 -0800	[thread overview]
Message-ID: <20090131023925.GB12147@kroah.com> (raw)
In-Reply-To: <20090131023906.GA12147@kroah.com>

[-- Attachment #1: fuse-destroy-bdi-on-umount.patch --]
[-- Type: text/plain, Size: 1757 bytes --]

2.6.27-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Miklos Szeredi <mszeredi@suse.cz>

commit 26c3679101dbccc054dcf370143941844ba70531 upstream.

If a fuse filesystem is unmounted but the device file descriptor
remains open and a new mount reuses the old device number, then the
mount fails with EEXIST and the following warning is printed in the
kernel log:

  WARNING: at fs/sysfs/dir.c:462 sysfs_add_one+0x35/0x3d()
  sysfs: duplicate filename '0:15' can not be created

The cause is that the bdi belonging to the fuse filesystem was
destoryed only after the device file was released.  Fix this by
calling bdi_destroy() from fuse_put_super() instead.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 fs/fuse/dev.c   |    3 ++-
 fs/fuse/inode.c |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

--- a/fs/fuse/dev.c
+++ b/fs/fuse/dev.c
@@ -281,7 +281,8 @@ static void request_end(struct fuse_conn
 			fc->blocked = 0;
 			wake_up_all(&fc->blocked_waitq);
 		}
-		if (fc->num_background == FUSE_CONGESTION_THRESHOLD) {
+		if (fc->num_background == FUSE_CONGESTION_THRESHOLD &&
+		    fc->connected) {
 			clear_bdi_congested(&fc->bdi, READ);
 			clear_bdi_congested(&fc->bdi, WRITE);
 		}
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -292,6 +292,7 @@ static void fuse_put_super(struct super_
 	list_del(&fc->entry);
 	fuse_ctl_remove_conn(fc);
 	mutex_unlock(&fuse_mutex);
+	bdi_destroy(&fc->bdi);
 	fuse_conn_put(fc);
 }
 
@@ -531,7 +532,6 @@ void fuse_conn_put(struct fuse_conn *fc)
 		if (fc->destroy_req)
 			fuse_request_free(fc->destroy_req);
 		mutex_destroy(&fc->inst_mutex);
-		bdi_destroy(&fc->bdi);
 		kfree(fc);
 	}
 }


  reply	other threads:[~2009-01-31  2:47 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090131023411.032399235@mini.kroah.org>
2009-01-31  2:39 ` [patch 00/32] 2.6.27-stable review Greg KH
2009-01-31  2:39   ` Greg KH [this message]
2009-01-31  2:39   ` [patch 02/32] fuse: fix missing fput on error Greg KH
2009-01-31  2:39   ` [patch 03/32] fuse: fix NULL deref in fuse_file_alloc() Greg KH
2009-01-31  2:39   ` [patch 04/32] inotify: clean up inotify_read and fix locking problems Greg KH
2009-01-31  2:39   ` [patch 05/32] mac80211: decrement ref count to netdev after launching mesh discovery Greg KH
2009-01-31  2:39   ` [patch 06/32] sysfs: fix problems with binary files Greg KH
2009-01-31  2:39   ` [patch 07/32] x86, mm: fix pte_free() Greg KH
2009-01-31  2:39   ` [patch 08/32] alpha: nautilus - fix compile failure with gcc-4.3 Greg KH
2009-01-31  2:39   ` [patch 09/32] it821x: Add ultra_mask quirk for Vortex86SX Greg KH
2009-01-31  2:40   ` [patch 10/32] libata: pata_via: support VX855, future chips whose IDE controller use 0x0571 Greg KH
2009-01-31  2:40   ` [patch 11/32] rtl8187: Add termination packet to prevent stall Greg KH
2009-01-31  2:40   ` [patch 12/32] serial_8250: support for Sealevel Systems Model 7803 COMM+8 Greg KH
2009-01-31  2:40   ` [patch 13/32] SUNRPC: Fix a memory leak in rpcb_getport_async Greg KH
2009-01-31  2:40   ` [patch 14/32] SUNRPC: Fix autobind on cloned rpc clients Greg KH
2009-01-31  2:40   ` [patch 15/32] USB: fix char-device disconnect handling Greg KH
2009-01-31  2:40   ` [patch 16/32] USB: storage: add unusual devs entry Greg KH
2009-01-31  2:40   ` [patch 17/32] USB: usbmon: Implement compat_ioctl Greg KH
2009-01-31  2:40   ` [patch 18/32] ALSA: hda - add another MacBook Pro 4, 1 subsystem ID Greg KH
2009-01-31  2:40   ` [patch 19/32] ALSA: hda - Add quirk for HP DV6700 laptop Greg KH
2009-01-31  2:40   ` [patch 20/32] ALSA: hda - Fix PCM reference NID for STAC/IDT analog outputs Greg KH
2009-01-31  2:40   ` [patch 21/32] bnx2x: Block nvram access when the device is inactive Greg KH
2009-01-31  2:40   ` [patch 22/32] crypto: authenc - Fix zero-length IV crash Greg KH
2009-01-31  2:40   ` [patch 23/32] crypto: ccm - Fix handling of null assoc data Greg KH
2009-01-31  2:40   ` [patch 24/32] epoll: drop max_user_instances and rely only on max_user_watches Greg KH
2009-01-31  2:40   ` [patch 25/32] ext3: Add sanity check to make_indexed_dir Greg KH
2009-01-31  2:40   ` [patch 26/32] include/linux: Add bsg.h to the Kernel exported headers Greg KH
2009-01-31  2:40   ` [patch 27/32] sgi-xpc: ensure flags are updated before bte_copy Greg KH
2009-01-31  2:40   ` [patch 28/32] sgi-xpc: Remove NULL pointer dereference Greg KH
2009-01-31  2:40   ` [patch 29/32] sound: virtuoso: do not overwrite EEPROM on Xonar D2/D2X Greg KH
2009-01-31  2:40   ` [patch 30/32] rtl8187: Fix error in setting OFDM power settings for RTL8187L Greg KH
2009-01-31  2:40   ` [patch 31/32] PCI hotplug: fix lock imbalance in pciehp Greg KH
2009-01-31  2:40   ` [patch 32/32] relay: fix lock imbalance in relay_late_setup_files Greg KH
2009-01-31  2:57   ` For -stable: sata_mv: fix 8-port timeouts on 508x/6081 chips Mark Lord
2009-01-31  3:11     ` [stable] " Greg KH
2009-01-31 19:24     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090131023925.GB12147@kroah.com \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=eteo@redhat.com \
    --cc=jake@lwn.net \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=mszeredi@suse.cz \
    --cc=rbranco@la.checkpoint.com \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=w@1wt.eu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox