public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@lst.de>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Ingo Molnar <mingo@elte.hu>, Pavel Emelyanov <xemul@openvz.org>,
	Vitaliy Gusev <vgusev@openvz.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] kthreads: move sched-realeted initialization from kthreadd context
Date: Sat, 31 Jan 2009 21:17:16 +1030	[thread overview]
Message-ID: <200901312117.17082.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090130123350.GA26206@redhat.com>

On Friday 30 January 2009 23:03:50 Oleg Nesterov wrote:
> (on top of kthread-dont-looking-for-a-task-in-create_kthread-2.patch)

Hi Oleg,

   Thanks for the cc: Vitaliy, I never saw that patch.  I've included it in my queue now.

As to this patch, it seems marginal.  I've never been convinced that we should
be trying to rescue root if they choose to set kthreadd's prio anyway, but I'm also wondering why we care about kthread_create scalability!

Still, I'm happy to apply it with one change:

> +		/*
> +		 * root may have changed our (kthreadd's) priority or CPU mask.
> +		 * The kernel thread should not inherit these properties.
> +		 */
> +		sched_setscheduler_nocheck(create.result, SCHED_NORMAL, &param);
> +		set_user_nice(create.result, KTHREAD_NICE_LEVEL);
> +		set_cpus_allowed_ptr(create.result, CPU_MASK_ALL_PTR);

cpu_all_mask is the non-deprecated replacement for CPU_MASK_ALL_PTR.

Thanks!
Rusty.

  reply	other threads:[~2009-01-31 10:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-30 12:33 [PATCH 1/4] kthreads: move sched-realeted initialization from kthreadd context Oleg Nesterov
2009-01-31 10:47 ` Rusty Russell [this message]
2009-02-01 10:38   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200901312117.17082.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=vgusev@openvz.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox