From: Rusty Russell <rusty@rustcorp.com.au>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ingo Molnar <mingo@elte.hu>, Pavel Emelyanov <xemul@openvz.org>,
Vitaliy Gusev <vgusev@openvz.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] kthreads: simplify the startup synchronization
Date: Sat, 31 Jan 2009 22:09:40 +1030 [thread overview]
Message-ID: <200901312209.41548.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090130123354.GA26213@redhat.com>
On Friday 30 January 2009 23:03:54 Oleg Nesterov wrote:
> We use two completions two create the kernel thread, this is a bit ugly.
> kthread() wakes up create_kthread() via ->started, then create_kthread()
> wakes up the caller kthread_create() via ->done. But kthread() does not
> need to wait for kthread(), it can just return. Instead kthread() itself
> can wake up the caller of kthread_create().
>
> Kill kthread_create_info->started, ->done is enough. This improves the
> scalability a bit and sijmplifies the code.
>
> The only problem if kernel_thread() fails, in that case create_kthread()
> must do complete(&create->done).
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Nice! I'll apply this one after the minor respin of 1/4.
Thanks,
Rusty.
prev parent reply other threads:[~2009-01-31 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 12:33 [PATCH 2/4] kthreads: simplify the startup synchronization Oleg Nesterov
2009-01-31 11:39 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901312209.41548.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=vgusev@openvz.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox