* [RFC][PATCH] devpts: Must release s_umount on error
@ 2009-01-29 6:33 Sukadev Bhattiprolu
2009-02-01 16:33 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Sukadev Bhattiprolu @ 2009-01-29 6:33 UTC (permalink / raw)
To: Alan Cox, hpa, hch
Cc: serue, David C. Hansen, Containers, linux-kernel, sukadev
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Date: Wed, 28 Jan 2009 16:57:12 -0800
Subject: [RFC][PATCH] devpts: Must release s_umount on error
We should drop the ->s_umount mutex if an error occurs after the
sget()/grab_super() call. This was introduced when adding support
for multiple instances of devpts and noticed during a code review/reorg.
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
---
fs/devpts/inode.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
index d008105..ad186b4 100644
--- a/fs/devpts/inode.c
+++ b/fs/devpts/inode.c
@@ -390,6 +390,7 @@ static int new_pts_mount(struct file_system_type *fs_type, int flags,
fail:
dput(mnt->mnt_sb->s_root);
+ up_write(&mnt->mnt_sb->s_umount);
deactivate_super(mnt->mnt_sb);
return err;
}
@@ -479,6 +480,7 @@ static int init_pts_mount(struct file_system_type *fs_type, int flags,
err = mknod_ptmx(mnt->mnt_sb);
if (err) {
dput(mnt->mnt_sb->s_root);
+ up_write(&mnt->mnt_sb->s_umount);
deactivate_super(mnt->mnt_sb);
}
--
1.5.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC][PATCH] devpts: Must release s_umount on error
2009-01-29 6:33 [RFC][PATCH] devpts: Must release s_umount on error Sukadev Bhattiprolu
@ 2009-02-01 16:33 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2009-02-01 16:33 UTC (permalink / raw)
To: Sukadev Bhattiprolu
Cc: Alan Cox, hpa, hch, serue, David C. Hansen, Containers,
linux-kernel, sukadev
On Wed, Jan 28, 2009 at 10:33:30PM -0800, Sukadev Bhattiprolu wrote:
>
> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> Date: Wed, 28 Jan 2009 16:57:12 -0800
> Subject: [RFC][PATCH] devpts: Must release s_umount on error
>
> We should drop the ->s_umount mutex if an error occurs after the
> sget()/grab_super() call. This was introduced when adding support
> for multiple instances of devpts and noticed during a code review/reorg.
Looks good and should probably be submitted for 2.6.29.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-01 16:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-29 6:33 [RFC][PATCH] devpts: Must release s_umount on error Sukadev Bhattiprolu
2009-02-01 16:33 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox