From: Christoph Hellwig <hch@lst.de>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: Christoph Hellwig <hch@lst.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
hpa@zytor.com, serue@us.ibm.com,
"David C. Hansen" <haveblue@us.ibm.com>,
Containers <containers@lists.osdl.org>,
linux-kernel@vger.kernel.org, sukadev@us.ibm.com
Subject: Re: [RFC][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts
Date: Sun, 1 Feb 2009 17:34:40 +0100 [thread overview]
Message-ID: <20090201163440.GE3416@lst.de> (raw)
In-Reply-To: <20090129064547.GB23160@us.ibm.com>
On Wed, Jan 28, 2009 at 10:45:47PM -0800, Sukadev Bhattiprolu wrote:
> + fsi = DEVPTS_SB(s);
> + opts = &fsi->mount_opts;
> + parse_mount_options(data, PARSE_REMOUNT, opts);
You could probably get rid of at least the fsi variable without making the
code less readable. Independent of these cosmetic bits the patch looks
good to me.
next prev parent reply other threads:[~2009-02-01 16:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 6:42 [RFC][PATCH 0/5] Simplify devpts code Sukadev Bhattiprolu
2009-01-29 6:45 ` [RFC][PATCH 1/5] Unroll essentials of do_remount_sb() into devpts Sukadev Bhattiprolu
2009-02-01 16:34 ` Christoph Hellwig [this message]
2009-01-29 6:46 ` [RFC][PATCH 2/5] Parse mount options just once and copy them to super block Sukadev Bhattiprolu
2009-02-01 16:35 ` Christoph Hellwig
2009-01-29 6:46 ` [RFC][PATCH 3/5] Move common mknod_ptmx() calls into caller Sukadev Bhattiprolu
2009-02-01 16:36 ` Christoph Hellwig
2009-01-29 6:47 ` [RFC][PATCH 4/5] Remove get_init_pts_sb() Sukadev Bhattiprolu
2009-02-01 16:37 ` Christoph Hellwig
2009-01-29 6:47 ` [RFC][PATCH 5/5] Merge code for single and multiple-instance mounts Sukadev Bhattiprolu
2009-02-01 16:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090201163440.GE3416@lst.de \
--to=hch@lst.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=containers@lists.osdl.org \
--cc=haveblue@us.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox