From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755100AbZBARYb (ORCPT ); Sun, 1 Feb 2009 12:24:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752547AbZBARYQ (ORCPT ); Sun, 1 Feb 2009 12:24:16 -0500 Received: from fg-out-1718.google.com ([72.14.220.158]:51302 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709AbZBARYO (ORCPT ); Sun, 1 Feb 2009 12:24:14 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-disposition:message-id:content-type :content-transfer-encoding; b=gmZXxmEuJTMQGMdq2TPl7FtPJyAzxyNPu4+2pxAAiC3Y/3t53QIYRtNdKwmUwu7S4n QBdYgY1KrSGxoHZdmPLolKEw7Yc++67SSUkqS+rE/YqtoT0/TPum0IG7OJStiis5jAJ9 /xanBgfXVK77+RnNOAQR2FJAGivjRA0TU34oA= From: Bartlomiej Zolnierkiewicz To: petkovbb@gmail.com Subject: Re: [PATCH 1/3] ide-cd: use ide_drive_t's rq in cdrom_queue_request_sense Date: Sun, 1 Feb 2009 17:04:50 +0100 User-Agent: KMail/1.10.4 (Linux/2.6.29-rc2-next-20090126; KDE/4.1.4; i686; ; ) Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org References: <1233002440-4325-1-git-send-email-petkovbb@gmail.com> <200901271607.10869.bzolnier@gmail.com> <9ea470500901270847m40264331le1092dc1589ec9de@mail.gmail.com> In-Reply-To: <9ea470500901270847m40264331le1092dc1589ec9de@mail.gmail.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200902011704.51726.bzolnier@gmail.com> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 27 January 2009, Borislav Petkov wrote: > On Tue, Jan 27, 2009 at 4:07 PM, Bartlomiej Zolnierkiewicz > wrote: > > On Monday 26 January 2009, Borislav Petkov wrote: > >> There should be no functionality change resulting from this patch. > >> > >> Suggested-by: Bartlomiej Zolnierkiewicz > >> Signed-off-by: Borislav Petkov > >> --- > >> drivers/ide/ide-cd.c | 2 +- > >> 1 files changed, 1 insertions(+), 1 deletions(-) > >> > >> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c > >> index d3d5fb6..3907466 100644 > >> --- a/drivers/ide/ide-cd.c > >> +++ b/drivers/ide/ide-cd.c > >> @@ -207,7 +207,7 @@ static void cdrom_queue_request_sense(ide_drive_t *drive, void *sense, > >> struct request *failed_command) > >> { > >> struct cdrom_info *info = drive->driver_data; > >> - struct request *rq = &info->request_sense_request; > >> + struct request *rq = &drive->request_sense_rq; > > > > Don't we want to also remove now unused ->request_sense_request? > > sure we do :) > > -- > From: Borislav Petkov > Date: Tue, 27 Jan 2009 17:42:28 +0100 > Subject: [PATCH 1/3] ide-cd: use ide_drive_t's rq in cdrom_queue_request_sense > > There should be no functionality change resulting from this patch. > > Suggested-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Borislav Petkov applied