From: Rusty Russell <rusty@rustcorp.com.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Mike Travis <travis@sgi.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] sched_rt: don't use first_cpu on cpumask created with cpumask_and.
Date: Sun, 1 Feb 2009 21:27:16 +1030 [thread overview]
Message-ID: <200902012127.17150.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090131134947.GA23973@elte.hu>
On Sunday 01 February 2009 00:19:47 Ingo Molnar wrote:
>
> * Rusty Russell <rusty@rustcorp.com.au> wrote:
>
> > Ingo, please apply to tip/urgent.
> >
> > cpumask_and() only initializes nr_cpu_ids bits, so the (deprecated)
> > first_cpu() might find one of those uninitialized bits if nr_cpu_ids
> > is less than NR_CPUS (as it can be for CONFIG_CPUMASK_OFFSTACK).
> >
> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> > ---
> > kernel/sched_rt.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Applied to tip/sched/urgent, thanks Rusty!
>
> Also, Git sorted out the same-content merge with this commit in cpus4096
> just fine:
>
> d38b223: cpumask: reduce stack usage in find_lowest_rq
>
> (this commit is where you backported it from i suspect?)
No, this was a clean audit on current Linus' tree. I wanted to make sure that
what Linus had worked...
Thanks,
Rusty.
prev parent reply other threads:[~2009-02-01 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 12:51 [PATCH] sched_rt: don't use first_cpu on cpumask created with cpumask_and Rusty Russell
2009-01-31 13:49 ` Ingo Molnar
2009-02-01 10:57 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902012127.17150.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox