The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux PCI <linux-pci@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/3] PCI PM: Do not disable and enable bridges during suspend-resume
Date: Sun, 1 Feb 2009 22:31:17 +0100	[thread overview]
Message-ID: <200902012231.17933.rjw@sisk.pl> (raw)
In-Reply-To: <200902012229.27517.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

It is a mistake to disable and enable PCI bridges and PCI Express
ports during suspend-resume (at least at the time when it is
currently done).  Disabling them may lead to problems with accessing
devices behind them and they should be automatically enabled when
their standard config spaces are restored.  Fix this by not attempting
to disable bridges during suspend and enable them during resume.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 drivers/pci/pci-driver.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Index: linux-2.6/drivers/pci/pci-driver.c
===================================================================
--- linux-2.6.orig/drivers/pci/pci-driver.c
+++ linux-2.6/drivers/pci/pci-driver.c
@@ -428,16 +428,18 @@ static int pci_pm_default_resume(struct 
 {
 	pci_fixup_device(pci_fixup_resume, pci_dev);
 
-	if (!pci_is_bridge(pci_dev))
-		pci_enable_wake(pci_dev, PCI_D0, false);
+	if (pci_is_bridge(pci_dev))
+		return 0;
 
+	pci_enable_wake(pci_dev, PCI_D0, false);
 	return pci_pm_reenable_device(pci_dev);
 }
 
 static void pci_pm_default_suspend_generic(struct pci_dev *pci_dev)
 {
-	/* If device is enabled at this point, disable it */
-	pci_disable_enabled_device(pci_dev);
+	/* If a non-bridge device is enabled at this point, disable it */
+	if (!pci_is_bridge(pci_dev))
+		pci_disable_enabled_device(pci_dev);
 	/*
 	 * Save state with interrupts enabled, because in principle the bus the
 	 * device is on may be put into a low power state after this code runs.


  reply	other threads:[~2009-02-01 21:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-01 21:29 [PATCH 0/3] PCI PM: More refinements of suspend-resume framework Rafael J. Wysocki
2009-02-01 21:31 ` Rafael J. Wysocki [this message]
2009-02-07  9:50   ` [PATCH 1/3] PCI PM: Do not disable and enable bridges during suspend-resume Pavel Machek
2009-02-07 13:48     ` Rafael J. Wysocki
2009-02-08  9:11       ` Pavel Machek
2009-02-08 13:23         ` Rafael J. Wysocki
2009-02-09  9:39           ` Pavel Machek
2009-02-10  0:21             ` Rafael J. Wysocki
2009-02-01 21:33 ` [PATCH 2/3] PCI PM: Let the core be more careful with respect to drivers using new framework Rafael J. Wysocki
2009-02-02  2:06   ` [linux-pm] " Nigel Cunningham
2009-02-02 12:04     ` Rafael J. Wysocki
2009-02-02 17:27       ` Rafael J. Wysocki
2009-02-01 21:34 ` [PATCH 3/3] PCI PM: Make warning in pci_legacy_suspend more useful Rafael J. Wysocki
2009-02-02  2:10   ` [linux-pm] " Nigel Cunningham
2009-02-02 12:02     ` Rafael J. Wysocki
2009-02-02 18:32 ` [PATCH 0/3] PCI PM: More refinements of suspend-resume framework Jesse Barnes
2009-02-03  3:25   ` Linus Torvalds
2009-02-03  8:26     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902012231.17933.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox