From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757393AbZBBUtT (ORCPT ); Mon, 2 Feb 2009 15:49:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753579AbZBBUtB (ORCPT ); Mon, 2 Feb 2009 15:49:01 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:57539 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753396AbZBBUtA (ORCPT ); Mon, 2 Feb 2009 15:49:00 -0500 Date: Mon, 2 Feb 2009 12:48:22 -0800 From: Andrew Morton To: Cheng Renquan Cc: rth@twiddle.net, linux-alpha@vger.kernel.org, ink@jurassic.park.msu.ru, viro@zeniv.linux.org.uk, cr_quan@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] do_pipe cleanup: drop its last user in arch/alpha/ Message-Id: <20090202124822.ed2deb84.akpm@linux-foundation.org> In-Reply-To: <1232772231-6523-1-git-send-email-crquan@gmail.com> References: <1232772231-6523-1-git-send-email-crquan@gmail.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 24 Jan 2009 12:43:50 +0800 Cheng Renquan wrote: > --- a/arch/alpha/kernel/osf_sys.c > +++ b/arch/alpha/kernel/osf_sys.c > @@ -46,7 +46,7 @@ > #include > #include > > -extern int do_pipe(int *); > +extern int do_pipe_flags(int *, int); From: Andrew Morton WARNING: externs should be avoided in .c files #42: FILE: arch/alpha/kernel/osf_sys.c:49: +extern int do_pipe_flags(int *, int); total: 0 errors, 1 warnings, 36 lines checked ./patches/do_pipe-drop-its-last-user-in-arch-alpha.patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Al Viro Cc: Cheng Renquan Cc: Ivan Kokshaysky Cc: Jens Axboe Cc: Richard Henderson Signed-off-by: Andrew Morton --- arch/alpha/kernel/osf_sys.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -puN arch/alpha/kernel/osf_sys.c~do_pipe-drop-its-last-user-in-arch-alpha-checkpatch-fixes arch/alpha/kernel/osf_sys.c --- a/arch/alpha/kernel/osf_sys.c~do_pipe-drop-its-last-user-in-arch-alpha-checkpatch-fixes +++ a/arch/alpha/kernel/osf_sys.c @@ -14,6 +14,7 @@ #include #include #include +#include #include #include #include @@ -46,8 +47,6 @@ #include #include -extern int do_pipe_flags(int *, int); - /* * Brk needs to return an error. Still support Linux's brk(0) query idiom, * which OSF programs just shouldn't be doing. We're still not quite _ OK?