From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755836AbZBBOM5 (ORCPT ); Mon, 2 Feb 2009 09:12:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753703AbZBBOMl (ORCPT ); Mon, 2 Feb 2009 09:12:41 -0500 Received: from e23smtp02.au.ibm.com ([202.81.31.144]:50432 "EHLO e23smtp02.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753230AbZBBOMk (ORCPT ); Mon, 2 Feb 2009 09:12:40 -0500 Date: Mon, 2 Feb 2009 19:42:33 +0530 From: Balbir Singh To: KOSAKI Motohiro Cc: KAMEZAWA Hiroyuki , Andrew Morton , "linux-kernel@vger.kernel.org" , "nishimura@mxp.nes.nec.co.jp" , "lizf@cn.fujitsu.com" , "linux-mm@kvack.org" Subject: Re: [-mm patch] Show memcg information during OOM Message-ID: <20090202141233.GD918@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20090202125240.GA918@balbir.in.ibm.com> <20090202215527.EC92.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20090202215527.EC92.KOSAKI.MOTOHIRO@jp.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * KOSAKI Motohiro [2009-02-02 21:59:34]: > Hi > > > +void mem_cgroup_print_mem_info(struct mem_cgroup *memcg) > > +{ > > + printk(KERN_WARNING "Memory cgroups's name %s\n", > > + memcg->css.cgroup->dentry->d_name.name); > > + printk(KERN_WARNING "Memory cgroup RSS : usage %llu, limit %llu" > > + " failcnt %llu\n", res_counter_read_u64(&memcg->res, RES_USAGE), > > + res_counter_read_u64(&memcg->res, RES_LIMIT), > > + res_counter_read_u64(&memcg->res, RES_FAILCNT)); > > + printk(KERN_WARNING "Memory cgroup swap: usage %llu, limit %llu " > > + "failcnt %llu\n", res_counter_read_u64(&memcg->res, RES_USAGE), > > + res_counter_read_u64(&memcg->res, RES_LIMIT), > > + res_counter_read_u64(&memcg->res, RES_FAILCNT)); > > s/res/memsw/ ? > > and, I don't like the name of "Memory cgroup RSS" and "Memory cgroup swap". > it seems misleading. memcg->res doesn't only count count rss, but also cache. > memcg->memsw doesn't only count swap, but also memory. > > otherthing, I think it is good patch for me :) > Good point, I fixed the res/memsw problem and sent out a patch. About the RSS thing, not sure what to call it, just calling it memory can be confusing, may be I should call it Memory and Memory+swap Thanks for the review -- Balbir