From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
Jens Axboe <jens.axboe@oracle.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH tip 0/3] tracing/blkftrace improvements
Date: Mon, 2 Feb 2009 20:28:36 -0200 [thread overview]
Message-ID: <20090202222836.GA12082@ghostprotocols.net> (raw)
In-Reply-To: <20090130172102.GB8754@ghostprotocols.net>
Em Fri, Jan 30, 2009 at 03:21:02PM -0200, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Jan 30, 2009 at 11:56:41AM -0500, Steven Rostedt escreveu:
> >
> > Frederic and Arnaldo,
> >
> > I'm fine with this change. Are there other changes you are going to put on
> > top of this, or should I wait for new stuff before pulling it in and
> > sendingo it to Ingo?
>
> Steve, please wait a bit, I'm reworking these changes so that they have
> a first solid user in blktrace, I'll post it later today.
OK, here it is, please take a look to see if it is acceptable.
Frederic, I kept you as the author for the first patch, as I just
trimmed it a little bit, lemme know if this is OK with you.
I removed the callbacks from the patch Frederic submitted, I think its
better to have the functions as a library, i.e. if a tracer wants to
disable the standard context info for one of its callbacks, it can just
call the function for the callbacks it wants.
Then I converted the tracer_event print callbacks to match the struct
trace print callback parameter list, i.e. to pass the trace_iterator,
from where we can get the trace_seq and the trace_entry, as well as
other stuff such as the timestamp.
The last patch makes use of this changes in blktrace, to provide a
binary trace that doesn't use the standard context info and that uses
the timestamp from the trace_iterator to synthesize most of the data
expected by the userspace blktrace utilities.
In the end I think I'll have to have the per cpu sequence numbers in the
ftrace plugin to be able to provide exactly what the userspace utilities
expect as I couldn't find a way to get it from the ring_buffer or
tracing guts (struct trace_array, etc) :-\
- Arnaldo
prev parent reply other threads:[~2009-02-02 22:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 8:59 [PATCH] tracing/ftrace: better manage the context info for events Frederic Weisbecker
2009-01-30 9:02 ` Frederic Weisbecker
2009-01-30 12:34 ` Arnaldo Carvalho de Melo
2009-01-30 12:39 ` Arnaldo Carvalho de Melo
2009-01-30 12:55 ` Frédéric Weisbecker
2009-01-30 13:21 ` Arnaldo Carvalho de Melo
2009-01-30 13:54 ` Arnaldo Carvalho de Melo
2009-01-30 14:14 ` Frédéric Weisbecker
2009-01-30 16:56 ` Steven Rostedt
2009-01-30 17:21 ` Arnaldo Carvalho de Melo
2009-02-02 22:28 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090202222836.GA12082@ghostprotocols.net \
--to=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox