Re: checkpatch.pl is getting too slow

[Greg KH <greg@kroah.com>]

On Sun, Feb 01, 2009 at 09:47:26AM -0800, Daniel Walker wrote:
> 
> 
> I found a little more on this.. It seems the problem with #define lines
> only causes a few extra seconds delay .. I found another issue C99 style
> comments.
> 
> On line 642 your file has this line,
> 
> // For the UART control registers, the application number need to be Or'ed
> 
> The quote in Or'ed causes checkpatch to treat the rest of the file as a
> big string that never closes. Or that's my impression. The delay is
> caused in the same way as the define delay. In order to check one line
> in the file the rest of the file is scanned.
> 
> The fix below increased the number of errors found too.
> 
> total: 347 errors, 278 warnings, 3932 lines checked

Nice, this looks good to me, thanks for figuring this out.

Andy, any thoughts?

greg k-h